From: Philipp Zabel <p.zabel@pengutronix.de>
To: linux-media@vger.kernel.org
Cc: Steve Longerbeam <steve_longerbeam@mentor.com>,
Marek Vasut <marex@denx.de>, Hans Verkuil <hverkuil@xs4all.nl>,
kernel@pengutronix.de, Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH 12/22] [media] tc358743: put lanes in STOP state before starting streaming
Date: Fri, 7 Oct 2016 18:00:57 +0200 [thread overview]
Message-ID: <20161007160107.5074-13-p.zabel@pengutronix.de> (raw)
In-Reply-To: <20161007160107.5074-1-p.zabel@pengutronix.de>
Without calling tc358743_set_csi from the new prepare_stream callback
(or calling tc358743_s_dv_timings or tc358743_set_fmt from userspace
after stopping the stream), the i.MX6 MIPI CSI2 input fails waiting
for lanes to enter STOP state when streaming is started again.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/media/i2c/tc358743.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 1e3a0dd2..dfa45d2 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1463,6 +1463,14 @@ static int tc358743_g_mbus_config(struct v4l2_subdev *sd,
return 0;
}
+static int tc358743_prepare_stream(struct v4l2_subdev *sd)
+{
+ /* Put all lanes in PL-11 state (STOPSTATE) */
+ tc358743_set_csi(sd);
+
+ return 0;
+}
+
static int tc358743_s_stream(struct v4l2_subdev *sd, int enable)
{
enable_stream(sd, enable);
@@ -1637,6 +1645,7 @@ static const struct v4l2_subdev_video_ops tc358743_video_ops = {
.g_dv_timings = tc358743_g_dv_timings,
.query_dv_timings = tc358743_query_dv_timings,
.g_mbus_config = tc358743_g_mbus_config,
+ .prepare_stream = tc358743_prepare_stream,
.s_stream = tc358743_s_stream,
};
--
2.9.3
next prev parent reply other threads:[~2016-10-07 16:01 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 16:00 [PATCH 00/22] Basic i.MX IPUv3 capture support Philipp Zabel
2016-10-07 16:00 ` [PATCH 01/22] [media] v4l2-async: move code out of v4l2_async_notifier_register into v4l2_async_test_nofity_all Philipp Zabel
2016-10-07 16:30 ` Marek Vasut
2016-10-07 16:53 ` Philipp Zabel
2016-10-07 16:00 ` [PATCH 02/22] [media] v4l2-async: allow subdevices to add further subdevices to the notifier waiting list Philipp Zabel
2016-10-07 21:52 ` Sakari Ailus
2016-10-12 13:26 ` Philipp Zabel
2016-10-13 11:56 ` Sakari Ailus
2016-10-14 15:47 ` Philipp Zabel
2016-10-07 22:43 ` Sakari Ailus
2016-10-14 15:48 ` Philipp Zabel
2016-10-14 17:06 ` Ian Arkver
2016-10-14 17:30 ` Philipp Zabel
2016-10-07 16:00 ` [PATCH 03/22] [media] v4l: of: add v4l2_of_subdev_registered Philipp Zabel
2016-10-07 18:50 ` Marek Vasut
2016-10-14 15:48 ` Philipp Zabel
2016-10-07 22:50 ` Sakari Ailus
2016-10-14 15:49 ` Philipp Zabel
2016-10-07 16:00 ` [PATCH 04/22] [media] v4l2-subdev.h: add prepare_stream op Philipp Zabel
2016-10-07 23:16 ` Sakari Ailus
2016-10-14 15:48 ` Philipp Zabel
2016-10-16 22:59 ` Sakari Ailus
2016-10-07 16:00 ` [PATCH 05/22] [media] v4l2-async: add new subdevices to the tail of subdev_list Philipp Zabel
2016-10-07 16:00 ` [PATCH 06/22] [media] imx: Add i.MX SoC wide media device driver Philipp Zabel
2016-10-07 16:00 ` [PATCH 07/22] [media] imx: Add IPUv3 media common code Philipp Zabel
2016-10-17 7:04 ` Ian Arkver
2016-10-07 16:00 ` [PATCH 08/22] [media] imx-ipu: Add i.MX IPUv3 CSI subdevice driver Philipp Zabel
2016-10-07 16:00 ` [PATCH 09/22] [media] imx: Add i.MX IPUv3 capture driver Philipp Zabel
2016-10-07 16:00 ` [PATCH 10/22] [media] platform: add video-multiplexer subdevice driver Philipp Zabel
2016-10-07 16:00 ` [PATCH 11/22] [media] imx: Add i.MX MIPI CSI-2 " Philipp Zabel
2016-10-07 16:00 ` Philipp Zabel [this message]
2016-10-07 19:02 ` [PATCH 12/22] [media] tc358743: put lanes in STOP state before starting streaming Marek Vasut
2016-10-14 15:49 ` Philipp Zabel
2016-10-07 16:00 ` [PATCH 13/22] ARM: dts: imx6qdl: Add capture-subsystem node Philipp Zabel
2016-10-07 16:00 ` [PATCH 14/22] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections Philipp Zabel
2016-10-07 16:01 ` [PATCH 15/22] ARM: dts: imx6qdl: Add MIPI CSI-2 D-PHY compatible and clocks Philipp Zabel
2016-10-07 16:01 ` [PATCH 16/22] ARM: dts: nitrogen6x: Add dtsi for BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board Philipp Zabel
2016-10-10 15:48 ` [16/22] " Gary Bisson
2016-10-14 16:45 ` Philipp Zabel
2016-10-07 16:01 ` [PATCH 17/22] gpu: ipuv3: add ipu_csi_set_downsize Philipp Zabel
2016-10-07 16:01 ` [PATCH 18/22] [media] imx-ipuv3-csi: support downsizing Philipp Zabel
2016-10-07 19:01 ` Marek Vasut
2016-10-14 15:48 ` Philipp Zabel
2016-10-16 15:09 ` Marek Vasut
2016-10-07 16:01 ` [PATCH 19/22] [media] add mux and video interface bridge entity functions Philipp Zabel
2016-10-07 16:01 ` [PATCH 20/22] [media] video-multiplexer: set entity function to mux Philipp Zabel
2016-10-07 16:01 ` [PATCH 21/22] [media] imx: Set i.MX MIPI CSI-2 entity function to bridge Philipp Zabel
2016-10-07 16:01 ` [PATCH 22/22] [media] tc358743: set entity function to video interface bridge Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007160107.5074-13-p.zabel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=hverkuil@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=marex@denx.de \
--cc=steve_longerbeam@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox