* [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions
@ 2016-10-19 17:17 Jean-Baptiste Abbadie
2016-10-19 17:17 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues Jean-Baptiste Abbadie
2016-10-19 17:17 ` [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice Jean-Baptiste Abbadie
0 siblings, 2 replies; 7+ messages in thread
From: Jean-Baptiste Abbadie @ 2016-10-19 17:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Cc: Jean-Baptiste Abbadie
This is a series of minor patch to fix checkpatch.pl issues.
Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 58 +++++++++++++--------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index fe637ce8f4e7..188d045d44ad 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2057,67 +2057,67 @@ property_signed_read(fm_rssi, int, "%d")
DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
static struct device_attribute attrs[] = {
- __ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
+ __ATTR(power_state, 0644, bcm2048_power_state_read,
bcm2048_power_state_write),
- __ATTR(mute, S_IRUGO | S_IWUSR, bcm2048_mute_read,
+ __ATTR(mute, 0644, bcm2048_mute_read,
bcm2048_mute_write),
- __ATTR(audio_route, S_IRUGO | S_IWUSR, bcm2048_audio_route_read,
+ __ATTR(audio_route, 0644, bcm2048_audio_route_read,
bcm2048_audio_route_write),
- __ATTR(dac_output, S_IRUGO | S_IWUSR, bcm2048_dac_output_read,
+ __ATTR(dac_output, 0644, bcm2048_dac_output_read,
bcm2048_dac_output_write),
- __ATTR(fm_hi_lo_injection, S_IRUGO | S_IWUSR,
+ __ATTR(fm_hi_lo_injection, 0644,
bcm2048_fm_hi_lo_injection_read,
bcm2048_fm_hi_lo_injection_write),
- __ATTR(fm_frequency, S_IRUGO | S_IWUSR, bcm2048_fm_frequency_read,
+ __ATTR(fm_frequency, 0644, bcm2048_fm_frequency_read,
bcm2048_fm_frequency_write),
- __ATTR(fm_af_frequency, S_IRUGO | S_IWUSR,
+ __ATTR(fm_af_frequency, 0644,
bcm2048_fm_af_frequency_read,
bcm2048_fm_af_frequency_write),
- __ATTR(fm_deemphasis, S_IRUGO | S_IWUSR, bcm2048_fm_deemphasis_read,
+ __ATTR(fm_deemphasis, 0644, bcm2048_fm_deemphasis_read,
bcm2048_fm_deemphasis_write),
- __ATTR(fm_rds_mask, S_IRUGO | S_IWUSR, bcm2048_fm_rds_mask_read,
+ __ATTR(fm_rds_mask, 0644, bcm2048_fm_rds_mask_read,
bcm2048_fm_rds_mask_write),
- __ATTR(fm_best_tune_mode, S_IRUGO | S_IWUSR,
+ __ATTR(fm_best_tune_mode, 0644,
bcm2048_fm_best_tune_mode_read,
bcm2048_fm_best_tune_mode_write),
- __ATTR(fm_search_rssi_threshold, S_IRUGO | S_IWUSR,
+ __ATTR(fm_search_rssi_threshold, 0644,
bcm2048_fm_search_rssi_threshold_read,
bcm2048_fm_search_rssi_threshold_write),
- __ATTR(fm_search_mode_direction, S_IRUGO | S_IWUSR,
+ __ATTR(fm_search_mode_direction, 0644,
bcm2048_fm_search_mode_direction_read,
bcm2048_fm_search_mode_direction_write),
- __ATTR(fm_search_tune_mode, S_IRUGO | S_IWUSR,
+ __ATTR(fm_search_tune_mode, 0644,
bcm2048_fm_search_tune_mode_read,
bcm2048_fm_search_tune_mode_write),
- __ATTR(rds, S_IRUGO | S_IWUSR, bcm2048_rds_read,
+ __ATTR(rds, 0644, bcm2048_rds_read,
bcm2048_rds_write),
- __ATTR(rds_b_block_mask, S_IRUGO | S_IWUSR,
+ __ATTR(rds_b_block_mask, 0644,
bcm2048_rds_b_block_mask_read,
bcm2048_rds_b_block_mask_write),
- __ATTR(rds_b_block_match, S_IRUGO | S_IWUSR,
+ __ATTR(rds_b_block_match, 0644,
bcm2048_rds_b_block_match_read,
bcm2048_rds_b_block_match_write),
- __ATTR(rds_pi_mask, S_IRUGO | S_IWUSR, bcm2048_rds_pi_mask_read,
+ __ATTR(rds_pi_mask, 0644, bcm2048_rds_pi_mask_read,
bcm2048_rds_pi_mask_write),
- __ATTR(rds_pi_match, S_IRUGO | S_IWUSR, bcm2048_rds_pi_match_read,
+ __ATTR(rds_pi_match, 0644, bcm2048_rds_pi_match_read,
bcm2048_rds_pi_match_write),
- __ATTR(rds_wline, S_IRUGO | S_IWUSR, bcm2048_rds_wline_read,
+ __ATTR(rds_wline, 0644, bcm2048_rds_wline_read,
bcm2048_rds_wline_write),
- __ATTR(rds_pi, S_IRUGO, bcm2048_rds_pi_read, NULL),
- __ATTR(rds_rt, S_IRUGO, bcm2048_rds_rt_read, NULL),
- __ATTR(rds_ps, S_IRUGO, bcm2048_rds_ps_read, NULL),
- __ATTR(fm_rds_flags, S_IRUGO, bcm2048_fm_rds_flags_read, NULL),
- __ATTR(region_bottom_frequency, S_IRUGO,
+ __ATTR(rds_pi, 0444, bcm2048_rds_pi_read, NULL),
+ __ATTR(rds_rt, 0444, bcm2048_rds_rt_read, NULL),
+ __ATTR(rds_ps, 0444, bcm2048_rds_ps_read, NULL),
+ __ATTR(fm_rds_flags, 0444, bcm2048_fm_rds_flags_read, NULL),
+ __ATTR(region_bottom_frequency, 0444,
bcm2048_region_bottom_frequency_read, NULL),
- __ATTR(region_top_frequency, S_IRUGO,
+ __ATTR(region_top_frequency, 0444,
bcm2048_region_top_frequency_read, NULL),
- __ATTR(fm_carrier_error, S_IRUGO,
+ __ATTR(fm_carrier_error, 0444,
bcm2048_fm_carrier_error_read, NULL),
- __ATTR(fm_rssi, S_IRUGO,
+ __ATTR(fm_rssi, 0444,
bcm2048_fm_rssi_read, NULL),
- __ATTR(region, S_IRUGO | S_IWUSR, bcm2048_region_read,
+ __ATTR(region, 0644, bcm2048_region_read,
bcm2048_region_write),
- __ATTR(rds_data, S_IRUGO, bcm2048_rds_data_read, NULL),
+ __ATTR(rds_data, 0444, bcm2048_rds_data_read, NULL),
};
static int bcm2048_sysfs_unregister_properties(struct bcm2048_device *bdev,
--
2.10.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues
2016-10-19 17:17 [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
@ 2016-10-19 17:17 ` Jean-Baptiste Abbadie
2016-10-19 17:51 ` Greg Kroah-Hartman
2016-10-19 19:34 ` Johannes Stezenbach
2016-10-19 17:17 ` [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice Jean-Baptiste Abbadie
1 sibling, 2 replies; 7+ messages in thread
From: Jean-Baptiste Abbadie @ 2016-10-19 17:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Cc: Jean-Baptiste Abbadie
Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 188d045d44ad..f66bea631e8e 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -997,7 +997,7 @@ static int bcm2048_set_fm_search_tune_mode(struct bcm2048_device *bdev,
timeout = BCM2048_AUTO_SEARCH_TIMEOUT;
if (!wait_for_completion_timeout(&bdev->compl,
- msecs_to_jiffies(timeout)))
+ msecs_to_jiffies(timeout)))
dev_err(&bdev->client->dev, "IRQ timeout.\n");
if (value)
@@ -2202,7 +2202,7 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
}
/* interruptible_sleep_on(&bdev->read_queue); */
if (wait_event_interruptible(bdev->read_queue,
- bdev->rds_data_available) < 0) {
+ bdev->rds_data_available) < 0) {
retval = -EINTR;
goto done;
}
--
2.10.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues
2016-10-19 17:17 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues Jean-Baptiste Abbadie
@ 2016-10-19 17:51 ` Greg Kroah-Hartman
2016-10-19 18:10 ` Jean-Baptiste Abbadie
2016-10-19 19:34 ` Johannes Stezenbach
1 sibling, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2016-10-19 17:51 UTC (permalink / raw)
To: Jean-Baptiste Abbadie; +Cc: Mauro Carvalho Chehab, linux-media
On Wed, Oct 19, 2016 at 07:17:12PM +0200, Jean-Baptiste Abbadie wrote:
> Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
I can't take a patch with no changelog text, sorry.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues
2016-10-19 17:51 ` Greg Kroah-Hartman
@ 2016-10-19 18:10 ` Jean-Baptiste Abbadie
2016-10-19 18:21 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Jean-Baptiste Abbadie @ 2016-10-19 18:10 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jean-Baptiste Abbadie, Mauro Carvalho Chehab, linux-media
On 19/10/16 19:51, Greg Kroah-Hartman wrote:
> I can't take a patch with no changelog text, sorry.
Hello,
Should I add the changelog in the same thread or start a new thread ?
Sorry, for the mistakes that's my first submitted patch.
Regards,
Jean-Baptiste
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues
2016-10-19 18:10 ` Jean-Baptiste Abbadie
@ 2016-10-19 18:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2016-10-19 18:21 UTC (permalink / raw)
To: Jean-Baptiste Abbadie; +Cc: Mauro Carvalho Chehab, linux-media
On Wed, Oct 19, 2016 at 08:10:25PM +0200, Jean-Baptiste Abbadie wrote:
> On 19/10/16 19:51, Greg Kroah-Hartman wrote:
> > I can't take a patch with no changelog text, sorry.
> Hello,
>
> Should I add the changelog in the same thread or start a new thread ?
Whole new patch please.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues
2016-10-19 17:17 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues Jean-Baptiste Abbadie
2016-10-19 17:51 ` Greg Kroah-Hartman
@ 2016-10-19 19:34 ` Johannes Stezenbach
1 sibling, 0 replies; 7+ messages in thread
From: Johannes Stezenbach @ 2016-10-19 19:34 UTC (permalink / raw)
To: Jean-Baptiste Abbadie
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
On Wed, Oct 19, 2016 at 07:17:12PM +0200, Jean-Baptiste Abbadie wrote:
> Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 188d045d44ad..f66bea631e8e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -997,7 +997,7 @@ static int bcm2048_set_fm_search_tune_mode(struct bcm2048_device *bdev,
> timeout = BCM2048_AUTO_SEARCH_TIMEOUT;
>
> if (!wait_for_completion_timeout(&bdev->compl,
> - msecs_to_jiffies(timeout)))
> + msecs_to_jiffies(timeout)))
> dev_err(&bdev->client->dev, "IRQ timeout.\n");
>
> if (value)
> @@ -2202,7 +2202,7 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
> }
> /* interruptible_sleep_on(&bdev->read_queue); */
> if (wait_event_interruptible(bdev->read_queue,
> - bdev->rds_data_available) < 0) {
> + bdev->rds_data_available) < 0) {
FWIW, a better Subject: would be "fix indentation" because
"alignment issue" usually means some address not
aligned to some border.
HTH,
Johannes
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice
2016-10-19 17:17 [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
2016-10-19 17:17 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues Jean-Baptiste Abbadie
@ 2016-10-19 17:17 ` Jean-Baptiste Abbadie
1 sibling, 0 replies; 7+ messages in thread
From: Jean-Baptiste Abbadie @ 2016-10-19 17:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Cc: Jean-Baptiste Abbadie
Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index f66bea631e8e..607dd5285149 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -17,10 +17,6 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
- * 02110-1301 USA
*/
/*
--
2.10.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-10-19 19:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-19 17:17 [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
2016-10-19 17:17 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues Jean-Baptiste Abbadie
2016-10-19 17:51 ` Greg Kroah-Hartman
2016-10-19 18:10 ` Jean-Baptiste Abbadie
2016-10-19 18:21 ` Greg Kroah-Hartman
2016-10-19 19:34 ` Johannes Stezenbach
2016-10-19 17:17 ` [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice Jean-Baptiste Abbadie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox