From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:56391 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932594AbcJXRAK (ORCPT ); Mon, 24 Oct 2016 13:00:10 -0400 Date: Mon, 24 Oct 2016 12:00:07 -0500 From: Benoit Parrot To: Hans Verkuil CC: , Subject: Re: [Patch 00/35] media: ti-vpe: fixes and enhancements Message-ID: <20161024170007.GP31296@ti.com> References: <20160928211643.26298-1-bparrot@ti.com> <46c23700-5c4f-e379-846a-604cacc17f4f@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <46c23700-5c4f-e379-846a-604cacc17f4f@xs4all.nl> Sender: linux-media-owner@vger.kernel.org List-ID: Hans, Thank you for taking the time to review my patches. I'll update the patch set relating to your comments and submit a v2 shortly. Regards Benoit Hans Verkuil wrote on Mon [2016-Oct-17 16:35:01 +0200]: > On 09/28/2016 11:16 PM, Benoit Parrot wrote: > > This patch series is to publish a number of enhancements > > we have been carrying for a while. > > > > A number of bug fixes and feature enhancements have been > > included. > > > > We also need to prepare the way for the introduction of > > the VIP (Video Input Port) driver (coming soon) which > > has internal IP module in common with VPE. > > > > The relevant modules (vpdma, sc and csc) are therefore converted > > into individual kernel modules. > > Other than the few comments I made this patch series looks OK. > > You can add my > > Acked-by: Hans Verkuil > > to those patches where I didn't make any comments. > > Regards, > > Hans > > > > > Archit Taneja (1): > > media: ti-vpe: Use line average de-interlacing for first 2 frames > > > > Benoit Parrot (16): > > media: ti-vpe: vpdma: Make vpdma library into its own module > > media: ti-vpe: vpdma: Add multi-instance and multi-client support > > media: ti-vpe: vpdma: Add helper to set a background color > > media: ti-vpe: vpdma: Fix bus error when vpdma is writing a descriptor > > media: ti-vpe: vpe: Added MODULE_DEVICE_TABLE hint > > media: ti-vpe: vpdma: Corrected YUV422 data type label. > > media: ti-vpe: vpdma: RGB data type yield inverted data > > media: ti-vpe: vpe: Fix vb2 buffer cleanup > > media: ti-vpe: vpe: Enable DMABUF export > > media: ti-vpe: Make scaler library into its own module > > media: ti-vpe: scaler: Add debug support for multi-instance > > media: ti-vpe: vpe: Make sure frame size dont exceed scaler capacity > > media: ti-vpe: vpdma: Add RAW8 and RAW16 data types > > media: ti-vpe: Make colorspace converter library into its own module > > media: ti-vpe: csc: Add debug support for multi-instance > > media: ti-vpe: vpe: Add proper support single and multi-plane buffer > > > > Harinarayan Bhatta (2): > > media: ti-vpe: Increasing max buffer height and width > > media: ti-vpe: Free vpdma buffers in vpe_release > > > > Nikhil Devshatwar (16): > > media: ti-vpe: vpe: Do not perform job transaction atomically > > media: ti-vpe: Add support for SEQ_TB buffers > > media: ti-vpe: vpe: Return NULL for invalid buffer type > > media: ti-vpe: vpdma: Add support for setting max width height > > media: ti-vpe: vpdma: Add abort channel desc and cleanup APIs > > media: ti-vpe: vpdma: Make list post atomic operation > > media: ti-vpe: vpdma: Clear IRQs for individual lists > > media: ti-vpe: vpe: configure line mode separately > > media: ti-vpe: vpe: Setup srcdst parameters in start_streaming > > media: ti-vpe: vpe: Post next descriptor only for list complete IRQ > > media: ti-vpe: vpe: Add RGB565 and RGB5551 support > > media: ti-vpe: vpdma: allocate and maintain hwlist > > media: ti-vpe: sc: Fix incorrect optimization > > media: ti-vpe: vpdma: Fix race condition for firmware loading > > media: ti-vpe: vpdma: Use bidirectional cached buffers > > media: ti-vpe: vpe: Fix line stride for output motion vector > > > > drivers/media/platform/Kconfig | 14 + > > drivers/media/platform/ti-vpe/Makefile | 10 +- > > drivers/media/platform/ti-vpe/csc.c | 18 +- > > drivers/media/platform/ti-vpe/csc.h | 2 +- > > drivers/media/platform/ti-vpe/sc.c | 28 +- > > drivers/media/platform/ti-vpe/sc.h | 11 +- > > drivers/media/platform/ti-vpe/vpdma.c | 349 +++++++++++++++++++--- > > drivers/media/platform/ti-vpe/vpdma.h | 85 +++++- > > drivers/media/platform/ti-vpe/vpdma_priv.h | 130 ++++----- > > drivers/media/platform/ti-vpe/vpe.c | 450 ++++++++++++++++++++++++----- > > 10 files changed, 891 insertions(+), 206 deletions(-) > >