linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Jörg Otte" <jrg.otte@gmail.com>,
	"Patrick Boettcher" <patrick.boettcher@posteo.de>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference
Date: Wed, 9 Nov 2016 18:21:13 -0200	[thread overview]
Message-ID: <20161109182113.410aa996@vento.lan> (raw)
In-Reply-To: <CA+55aFwsYHbXFimTL137Zwbc0bhOmR+XzDnUBmM=Pgn+8xBnWw@mail.gmail.com>

Em Wed, 9 Nov 2016 11:07:35 -0800
Linus Torvalds <torvalds@linux-foundation.org> escreveu:

> On Wed, Nov 9, 2016 at 3:09 AM, Jörg Otte <jrg.otte@gmail.com> wrote:
> >
> > Tried patch with no success. Again a NULL ptr dereferece.  
> 
> That patch was pure garbage, I think. Pretty much all the other
> drivers that use the same approach will have the same issue. Adding
> that init function just for the semaphore is crazy.
> 
> I suspect a much simpler approach is to just miove the "data_mutex"
> away from the priv area and into "struct dvb_usb_device" and
> "dvb_usb_adapter". Sure, that grows those structures a tiny bit, and
> not every driver may need that mutex, but it simplifies things
> enormously. Mauro?

Yeah, makes sense.

I'll work on moving data_mutex to struct dvb_usb_device.

Thanks,
Mauro

  reply	other threads:[~2016-11-09 20:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-06 15:40 [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference Jörg Otte
2016-11-08 18:42 ` Linus Torvalds
2016-11-08 20:22   ` Mauro Carvalho Chehab
2016-11-08 21:15     ` Benjamin Larsson
2016-11-08 21:38       ` Mauro Carvalho Chehab
2016-11-09 19:57         ` Malcolm Priestley
2016-11-09 20:25           ` Mauro Carvalho Chehab
2016-11-09 11:09     ` Jörg Otte
2016-11-09 19:07       ` Linus Torvalds
2016-11-09 20:21         ` Mauro Carvalho Chehab [this message]
2016-11-10  8:40         ` Mauro Carvalho Chehab
2016-11-10 11:15           ` Jörg Otte
2016-11-11 13:55             ` Mauro Carvalho Chehab
2016-11-11 16:43               ` Jörg Otte
2016-11-12 18:24               ` Benjamin Larsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161109182113.410aa996@vento.lan \
    --to=mchehab@s-opensource.com \
    --cc=jrg.otte@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=patrick.boettcher@posteo.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).