linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: VDR User <user.vdr@gmail.com>
Cc: LMML <linux-media@vger.kernel.org>
Subject: Re: Question about 2 gp8psk patches I noticed, and possible bug.
Date: Sat, 12 Nov 2016 11:59:26 -0200	[thread overview]
Message-ID: <20161112115926.49fcd6cf@vela.lan> (raw)
In-Reply-To: <CAA7C2qi-NmpnRJO6DGmh9O1_21vK=Q82A_qkfBJ0ujYPakL6XQ@mail.gmail.com>

Em Sat, 12 Nov 2016 02:20:37 -0800
VDR User <user.vdr@gmail.com> escreveu:

> Ok, I think I had too much patching going on (I switched from 4.8.4
> kernel drivers to media_build) so I started from scratch with a fresh
> update to kernel 4.8.7. First I applied the dma stuff in this order:
> 
> (from https://patchwork.linuxtv.org/patch/37395/raw/)
> v2-18-31-gp8psk-don-t-do-DMA-on-stack.patch
> (from https://patchwork.linuxtv.org/patch/37386/raw/)
> v2-19-31-gp8psk-don-t-go-past-the-buffer-size.patch
> (from https://patchwork.linuxtv.org/patch/37929/raw/)
> media-gp8psk-fix-gp8psk_usb_in_op-logic.patch
> 
> It works fine at this point but we still have the attach bug. Then I applied:
> 
> (from https://patchwork.linuxtv.org/patch/38040/raw/)
> Question-about-2-gp8psk-patches-I-noticed-and-possible-bug..patch
> 
> Attach bug is fixed, tuning works, module unloads without crashing.
> Everything seems ok! I think the gp8psk issues are resolved with the
> above 4 patches. As you know, there are some other drivers which
> attach the same way as gp8psk was.
> 
> Thanks for your help & patience!

Great!

> 
> One quick question.. Shouldn't gp8psk_fe be listed in the "used by"
> column of dvb_usb_gp8psk or the other dvb_* modules?:
> 
> Module                  Size  Used by
> gp8psk_fe               3803  1

No, the way dvb_attach works don't list what modules use it.
There were a pathset fixing it back in 2008 or something, but
it were never applied upstream.

> dvb_usb_gp8psk          7344  19
> dvb_usb                17495  1 dvb_usb_gp8psk
> dvb_core               62327  1 dvb_usb




Cheers,
Mauro

      reply	other threads:[~2016-11-12 13:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAA7C2qjXSkmmCB=zc7Y-Btpwzm_B=_ok0t6qMRuCy+gfrEhcMw@mail.gmail.com>
2016-11-08 17:55 ` Question about 2 gp8psk patches I noticed, and possible bug Mauro Carvalho Chehab
2016-11-09  6:00   ` VDR User
2016-11-09  9:33     ` Mauro Carvalho Chehab
2016-11-09 15:37       ` VDR User
2016-11-09 15:49         ` VDR User
2016-11-09 17:35           ` Mauro Carvalho Chehab
2016-11-10  1:03             ` VDR User
2016-11-10  8:07               ` Mauro Carvalho Chehab
2016-11-10 15:01                 ` VDR User
2016-11-11 12:49                   ` Mauro Carvalho Chehab
2016-11-11 15:33                     ` VDR User
2016-11-11 21:53                       ` Mauro Carvalho Chehab
2016-11-11 22:10                         ` Mauro Carvalho Chehab
2016-11-12  4:45                           ` VDR User
2016-11-12  4:52                             ` VDR User
2016-11-12  5:21                               ` VDR User
2016-11-12  8:14                             ` Mauro Carvalho Chehab
2016-11-12 10:20                               ` VDR User
2016-11-12 13:59                                 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161112115926.49fcd6cf@vela.lan \
    --to=mchehab@s-opensource.com \
    --cc=linux-media@vger.kernel.org \
    --cc=user.vdr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).