From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] v4l: videodev2: Include linux/time.h for timeval and timespec structs
Date: Mon, 21 Nov 2016 12:08:36 -0200 [thread overview]
Message-ID: <20161121120836.638ea7c3@vento.lan> (raw)
In-Reply-To: <5832FBFC.6070004@linux.intel.com>
Em Mon, 21 Nov 2016 15:51:56 +0200
Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:
> Hi Mauro,
>
> On 11/21/16 15:33, Mauro Carvalho Chehab wrote:
> > Em Thu, 27 Oct 2016 13:50:51 +0300
> > Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:
> >
> >> struct timeval and struct timespec are defined in linux/time.h. Explicitly
> >> include the header if __KERNEL__ is defined.
> >
> > The patch below doesn't do what you're mentioned above. It unconditionally
> > include linux/time.h, and, for userspace, it will *also* include
> > sys/time.h...
>
> My bad... I thought writing a single line patch would be easy. ;-) Will fix.
>
> >
> > I suspect that this would cause problems on userspace.
> >
> > Btw, you didn't mention on your description what's the bug you're
> > trying to fix.
>
> The problem is a compiler error due to lacking defition for a struct.
> I'll add that to v2.
On userspace or Kernelspace? Please be clear at version 2, adding the
relevant info about how you got it.
Thanks,
Mauro
prev parent reply other threads:[~2016-11-21 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 10:50 [PATCH 1/1] v4l: videodev2: Include linux/time.h for timeval and timespec structs Sakari Ailus
2016-11-21 13:33 ` Mauro Carvalho Chehab
2016-11-21 13:51 ` Sakari Ailus
2016-11-21 14:08 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121120836.638ea7c3@vento.lan \
--to=mchehab@s-opensource.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).