From: Vincent McIntyre <vincent.mcintyre@gmail.com>
To: linux-media@vger.kernel.org
Subject: [patch] fix 'make install'
Date: Wed, 23 Nov 2016 22:37:11 +1100 [thread overview]
Message-ID: <20161123113709.GA14257@shambles.local> (raw)
Recent work on handling the case of no frame_vector.c in the kernel
seems to have ended up breaking the 'make install' target. The patch
below makes it work again for me, on ubuntu 16.04 LTS, amd64,
kernel 4.4.
Without it, I get this behavior:
moake -C /home/me/media_build/v4l install
make[1]: Entering directory '/home/me/media_build/v4l'
make[1]: *** No rule to make target 'mm-install', needed by 'install'. Stop.
make[1]: Leaving directory '/home/me/media_build/v4l'
Makefile:15: recipe for target 'install' failed
make: *** [install] Error 2
diff --git a/v4l/Makefile b/v4l/Makefile
index 28e8fb7..74a2633 100644
--- a/v4l/Makefile
+++ b/v4l/Makefile
@@ -210,8 +210,14 @@ all:: default
#################################################
# installation invocation rules
-
-modules_install install:: mm-install media-install firmware_install
+INSTALLDEPS :=
+ifeq ($(makefile-mm),1)
+INSTALLDEPS += mm-install
+endif
+ifeq ($(makefile-media),1)
+INSTALLDEPS += media-install
+endif
+modules_install install:: $(INSTALLDEPS) firmware_install
remove rminstall:: media-rminstall
Vince
reply other threads:[~2016-11-23 11:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123113709.GA14257@shambles.local \
--to=vincent.mcintyre@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox