From: Sean Young <sean@mess.org>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
"Timo Kokkonen" <timo.t.kokkonen@iki.fi>,
"Pavel Machek" <pavel@ucw.cz>,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH 1/5] [media] ir-rx51: port to rc-core
Date: Fri, 30 Dec 2016 13:07:52 +0000 [thread overview]
Message-ID: <20161230130752.GA7377@gofer.mess.org> (raw)
In-Reply-To: <5878d916-6a60-d5c3-b912-948b5b970661@gmail.com>
Hi Ivo,,
On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote:
> On 20.12.2016 19:50, Sean Young wrote:
> >This driver was written using lirc since rc-core did not support
> >transmitter-only hardware at that time. Now that it does, port
> >this driver.
> >
> >Compile tested only.
> >
>
> I guess after that change, there will be no more /dev/lircN device, right?
> Neither will LIRC_XXX IOCTL codes be supported?
Quite the opposite, /dev/lircN and all the LIRC_XXX ioctls will still be
supported through ir-lirc-codec.c.
By using rc-core, the driver will be more succinct, and some latent bugs
will be fixed. For example, at the moment it is possible to write hours
of IR data and keep the n900 from suspending.
I'm working on lirc scancode sending and receiving using the IR encoders,
and when that is in place, any rc-core driver will get it for free.
> That looks to me as a completely new driver, not a port to new API.
>
> Right now there are applications using the current behaviour (pierogi for
> example), which will be broken by the change.
Nothing should break.
Thanks,
Sean
next prev parent reply other threads:[~2016-12-30 13:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 17:50 [PATCH 0/5] Lirc staging drivers Sean Young
2016-12-20 17:50 ` [PATCH 1/5] [media] ir-rx51: port to rc-core Sean Young
2016-12-30 11:30 ` Ivaylo Dimitrov
2016-12-30 13:07 ` Sean Young [this message]
2016-12-30 13:30 ` Sean Young
2016-12-30 13:50 ` Ivaylo Dimitrov
2016-12-30 15:46 ` Sean Young
2017-01-16 10:10 ` Sean Young
2017-01-16 16:34 ` Ivaylo Dimitrov
2017-01-16 20:13 ` Pavel Machek
2017-01-30 16:26 ` Mauro Carvalho Chehab
2016-12-20 17:50 ` [PATCH 2/5] [media] staging: lirc_sir: " Sean Young
2016-12-20 17:50 ` [PATCH 3/5] [media] staging: lirc_parallel: remove Sean Young
2016-12-20 17:50 ` [PATCH 4/5] [media] staging: lirc_bt829: remove Sean Young
2016-12-20 17:50 ` [PATCH 5/5] [media] staging: lirc_imon: port remaining usb ids to imon and remove Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161230130752.GA7377@gofer.mess.org \
--to=sean@mess.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=timo.t.kokkonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).