From: Andrey Utkin <andrey_utkin@fastmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Andrey Utkin <andrey.utkin@corp.bluecherry.net>,
LKML <linux-kernel@vger.kernel.org>,
Bluecherry Maintainers <maintainers@bluecherrydvr.com>,
Ismael Luceno <ismael@iodev.co.uk>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] solo6x10: use designated initializers
Date: Sun, 8 Jan 2017 17:38:31 +0000 [thread overview]
Message-ID: <20170108173831.GB30556@dell-m4800> (raw)
In-Reply-To: <CAGXu5jKFA6MtEWOFm+HDb1yy1pp9uFoRDS02G4qqn-7wWK7P7A@mail.gmail.com>
On Fri, Jan 06, 2017 at 01:21:10PM -0800, Kees Cook wrote:
> > Since `ops` is static, what about this?
> > For the variant given below, you have my signoff.
> >
> >> --- a/drivers/media/pci/solo6x10/solo6x10-g723.c
> >> +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c
> >> @@ -350,7 +350,7 @@ static int solo_snd_pcm_init(struct solo_dev *solo_dev)
> >>
> >> int solo_g723_init(struct solo_dev *solo_dev)
> >> {
> >> - static struct snd_device_ops ops = { NULL };
> >> + static struct snd_device_ops ops;
>
> Ah! Yes, thanks. That works fine too. :) Can this be const as well?
No, it can't be const, it's used as parameter for snd_device_new() which
takes "struct snd_device_ops *".
prev parent reply other threads:[~2017-01-08 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 1:05 [PATCH] solo6x10: use designated initializers Kees Cook
2016-12-19 19:56 ` Andrey Utkin
2017-01-06 21:21 ` Kees Cook
2017-01-08 17:38 ` Andrey Utkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170108173831.GB30556@dell-m4800 \
--to=andrey_utkin@fastmail.com \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=ismael@iodev.co.uk \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox