From: Eric Anholt <eric@anholt.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>
Subject: [PATCH 2/6] staging: bcm2835-v4l2: Update the driver to the current VCHI API.
Date: Fri, 27 Jan 2017 13:54:59 -0800 [thread overview]
Message-ID: <20170127215503.13208-3-eric@anholt.net> (raw)
In-Reply-To: <20170127215503.13208-1-eric@anholt.net>
49bec49fd7f2 ("staging: vc04_services: remove vchiq_copy_from_user")
removed the flags/msg_handle arguments, which were unused, and pushed
the implementation of copying using memcpy vs copy_from_user to the
caller.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/staging/media/platform/bcm2835/mmal-vchiq.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c b/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
index 781322542d5a..24bd2948136c 100644
--- a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
+++ b/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
@@ -378,6 +378,14 @@ static int inline_receive(struct vchiq_mmal_instance *instance,
return 0;
}
+static ssize_t mmal_memcpy_wrapper(void *src, void *dst,
+ size_t offset, size_t size)
+{
+ memcpy(dst + offset, src + offset, size);
+
+ return size;
+}
+
/* queue the buffer availability with MMAL_MSG_TYPE_BUFFER_FROM_HOST */
static int
buffer_from_host(struct vchiq_mmal_instance *instance,
@@ -442,10 +450,9 @@ buffer_from_host(struct vchiq_mmal_instance *instance,
vchi_service_use(instance->handle);
- ret = vchi_msg_queue(instance->handle, &m,
+ ret = vchi_msg_queue(instance->handle, mmal_memcpy_wrapper, &m,
sizeof(struct mmal_msg_header) +
- sizeof(m.u.buffer_from_host),
- VCHI_FLAGS_BLOCK_UNTIL_QUEUED, NULL);
+ sizeof(m.u.buffer_from_host));
if (ret != 0) {
release_msg_context(msg_context);
@@ -731,9 +738,9 @@ static int send_synchronous_mmal_msg(struct vchiq_mmal_instance *instance,
vchi_service_use(instance->handle);
ret = vchi_msg_queue(instance->handle,
+ mmal_memcpy_wrapper,
msg,
- sizeof(struct mmal_msg_header) + payload_len,
- VCHI_FLAGS_BLOCK_UNTIL_QUEUED, NULL);
+ sizeof(struct mmal_msg_header) + payload_len);
vchi_service_release(instance->handle);
--
2.11.0
next prev parent reply other threads:[~2017-01-27 21:55 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 21:54 [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver Eric Anholt
2017-01-27 21:54 ` [PATCH 1/6] staging: Import the BCM2835 MMAL-based " Eric Anholt
2017-02-03 18:59 ` Mauro Carvalho Chehab
2017-02-05 22:15 ` Dave Stevenson
2017-02-05 23:13 ` Michael Zoran
2017-02-06 8:30 ` Greg Kroah-Hartman
2017-02-06 12:37 ` Mauro Carvalho Chehab
2017-02-06 15:01 ` Dave Stevenson
2017-02-06 9:08 ` Hans Verkuil
2017-02-06 11:37 ` Dave Stevenson
2017-02-06 12:58 ` Hans Verkuil
2017-02-06 15:21 ` Dave Stevenson
2017-02-06 16:00 ` Hans Verkuil
2017-02-10 9:47 ` Hans Verkuil
2017-02-06 12:59 ` Hans Verkuil
2017-01-27 21:54 ` Eric Anholt [this message]
2017-01-27 21:55 ` [PATCH 3/6] staging: bcm2835-v4l2: Add a build system for the module Eric Anholt
2017-01-29 14:12 ` Michael Zoran
2017-02-03 19:01 ` Mauro Carvalho Chehab
2017-01-27 21:55 ` [PATCH 4/6] staging: bcm2835-v4l2: Add a TODO file for improvements we need Eric Anholt
2017-01-27 21:55 ` [PATCH 5/6] staging: bcm2835-v4l2: Apply many whitespace fixes from checkpatch Eric Anholt
2017-01-27 21:55 ` [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling " Eric Anholt
2017-01-27 22:30 ` Joe Perches
2017-01-30 20:05 ` Eric Anholt
2017-01-31 1:38 ` Joe Perches
2017-01-31 18:30 ` Eric Anholt
2017-01-31 18:49 ` Joe Perches
2017-03-15 14:01 ` [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver Mauro Carvalho Chehab
2017-03-15 21:50 ` Stefan Wahren
2017-03-15 22:01 ` Eric Anholt
2017-03-16 1:08 ` Mauro Carvalho Chehab
2017-03-16 1:46 ` Michael Zoran
2017-03-16 9:29 ` Mauro Carvalho Chehab
2017-03-18 0:34 ` Eric Anholt
2017-03-19 16:58 ` Mauro Carvalho Chehab
2017-03-19 17:04 ` Michael Zoran
2017-03-20 1:11 ` Mauro Carvalho Chehab
2017-03-20 10:58 ` Mauro Carvalho Chehab
2017-03-20 11:08 ` Michael Zoran
2017-03-20 14:58 ` Mauro Carvalho Chehab
2017-03-20 15:11 ` Michael Zoran
2017-03-20 15:33 ` Mauro Carvalho Chehab
2017-03-20 15:40 ` Michael Zoran
2017-03-20 11:57 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127215503.13208-3-eric@anholt.net \
--to=eric@anholt.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).