From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Sakari Ailus <sakari.ailus@iki.fi>,
Tuukka Toivonen <tuukkat76@gmail.com>,
Pavel Machek <pavel@ucw.cz>
Cc: linux-media@vger.kernel.org
Subject: Re: [GIT PULL FOR v4.11] Add et8ek8 driver
Date: Tue, 31 Jan 2017 10:42:48 -0200 [thread overview]
Message-ID: <20170131104248.4e0f0bd8@vento.lan> (raw)
In-Reply-To: <20170125140745.GH7139@valkosipuli.retiisi.org.uk>
Em Wed, 25 Jan 2017 16:07:45 +0200
Sakari Ailus <sakari.ailus@iki.fi> escreveu:
> Hi Mauro,
>
> This pull request adds the sensor et8ek8 driver which is used on the Nokia
> N900. Please pull.
>
>
> The following changes since commit 40eca140c404505c09773d1c6685d818cb55ab1a:
>
> [media] mn88473: add DVB-T2 PLP support (2016-12-27 14:00:15 -0200)
>
> are available in the git repository at:
>
> ssh://linuxtv.org/git/sailus/media_tree.git et8ek8
>
> for you to fetch changes up to 1d26b93d5341d36cdd45b4d801f85d6c35128385:
>
> mark myself as mainainer for camera on N900 (2017-01-25 15:49:45 +0200)
>
> ----------------------------------------------------------------
> Pavel Machek (3):
> media: et8ek8: add device tree binding documentation
> media: Driver for Toshiba et8ek8 5MP sensor
> mark myself as mainainer for camera on N900
>
> .../bindings/media/i2c/toshiba,et8ek8.txt | 48 +
> MAINTAINERS | 8 +
> drivers/media/i2c/Kconfig | 1 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/et8ek8/Kconfig | 6 +
> drivers/media/i2c/et8ek8/Makefile | 2 +
> drivers/media/i2c/et8ek8/et8ek8_driver.c | 1515 ++++++++++++++++++++
> drivers/media/i2c/et8ek8/et8ek8_mode.c | 587 ++++++++
> drivers/media/i2c/et8ek8/et8ek8_reg.h | 96 ++
> 9 files changed, 2264 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> create mode 100644 drivers/media/i2c/et8ek8/Kconfig
> create mode 100644 drivers/media/i2c/et8ek8/Makefile
> create mode 100644 drivers/media/i2c/et8ek8/et8ek8_driver.c
> create mode 100644 drivers/media/i2c/et8ek8/et8ek8_mode.c
> create mode 100644 drivers/media/i2c/et8ek8/et8ek8_reg.h
>
That added a new warning:
drivers/media/i2c/et8ek8/et8ek8_driver.c: In function 'et8ek8_registered':
drivers/media/i2c/et8ek8/et8ek8_driver.c:1262:29: warning: variable 'format' set but not used [-Wunused-but-set-variable]
struct v4l2_mbus_framefmt *format;
^~~~~~
compilation succeeded
The driver is calling this function and storing it on a var
that is not used:
format = __et8ek8_get_pad_format(sensor, NULL, 0,
V4L2_SUBDEV_FORMAT_ACTIVE);
return 0;
Please send a fixup patch.
Thanks,
Mauro
next prev parent reply other threads:[~2017-01-31 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 14:07 [GIT PULL FOR v4.11] Add et8ek8 driver Sakari Ailus
2017-01-31 12:42 ` Mauro Carvalho Chehab [this message]
2017-01-31 12:45 ` Sakari Ailus
2017-01-31 13:01 ` Mauro Carvalho Chehab
2017-02-01 12:47 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131104248.4e0f0bd8@vento.lan \
--to=mchehab@s-opensource.com \
--cc=linux-media@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@iki.fi \
--cc=tuukkat76@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox