Re: linux-next: build failure after merge of the v4l-dvb tree

linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* Re: linux-next: build failure after merge of the v4l-dvb tree
       [not found]             ` <20170206091914.56836dd3@canb.auug.org.au>
@ 2017-02-05 22:22               ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2017-02-05 22:22 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Sean Young, linux-media

Em Mon, 6 Feb 2017 09:19:14 +1100
Stephen Rothwell <sfr@canb.auug.org.au> escreveu:

> Hi Mauro,
> 
> On Thu, 2 Feb 2017 22:24:35 -0200 Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote:
> >
> > So, if this is not a problem to you, maybe you can setup your
> > environment to pull (in this order) from:
> > 
> > 	git://linuxtv.org/media_tree.git fixes
> > 	git://linuxtv.org/media_tree.git master
> > 	git://linuxtv.org/mchehab/media-next.git master
> > 
> > Most of the time, the last pull won't get anything.  
> 
> OK, from today I have those three trees called v4l-dvb-fixes, v4l-dvb
> and v4l-dvb-next respectively.  We'll see how it goes.

OK!

Thanks!
Mauro

^ permalink raw reply	[flat|nested] 2+ messages in thread

[parent not found: <20121112110935.eee5f582f16ab07c9faeabb1@canb.auug.org.au>]

* Re: linux-next: build failure after merge of the v4l-dvb tree
       [not found] <20121112110935.eee5f582f16ab07c9faeabb1@canb.auug.org.au>
@ 2012-11-13 13:14 ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2012-11-13 13:14 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, linux-media

Em Mon, 12 Nov 2012 11:09:35 +1100
Stephen Rothwell <sfr@canb.auug.org.au> escreveu:

> Hi Mauro,
> 
> After merging the v4l-dvb tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "sms_ir_exit" [drivers/media/common/siano/smsmdtv.ko] undefined!
> ERROR: "sms_ir_event" [drivers/media/common/siano/smsmdtv.ko] undefined!
> ERROR: "sms_ir_init" [drivers/media/common/siano/smsmdtv.ko] undefined!
> 
> This is better than Friday, but still not quite there. :-(
> 
> I have used the v4l-dvb tree from next-20121026 again.

Sorry, I did one mistake on my last patch. Instead of adding RC to the
siano core, it was added at the build as if it was an independent module.

The fix is trivial. I'll add it on my tree for tomorrow's merge.

Thanks for pointing it.

Regards,
Mauro

-

[PATCH] [media] siano: fix build with allmodconfig

As reported by Stephen:

	After merging the v4l-dvb tree, today's linux-next build (x86_64
	allmodconfig) failed like this:

	ERROR: "sms_ir_exit" [drivers/media/common/siano/smsmdtv.ko] undefined!
	ERROR: "sms_ir_event" [drivers/media/common/siano/smsmdtv.ko] undefined!
	ERROR: "sms_ir_init" [drivers/media/common/siano/smsmdtv.ko] undefined!

The smsir file should be part of the smsmdtv core, if RC is defined.
Fix it.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/common/siano/Makefile b/drivers/media/common/siano/Makefile
index 9e7fdf2..81b1e98 100644
--- a/drivers/media/common/siano/Makefile
+++ b/drivers/media/common/siano/Makefile
@@ -3,7 +3,7 @@ smsmdtv-objs := smscoreapi.o sms-cards.o smsendian.o
 obj-$(CONFIG_SMS_SIANO_MDTV) += smsmdtv.o smsdvb.o
 
 ifeq ($(CONFIG_SMS_SIANO_RC),y)
-  obj-$(CONFIG_SMS_SIANO_MDTV) += smsir.o
+  smsmdtv-objs += smsir.o
 endif
 
 ccflags-y += -Idrivers/media/dvb-core

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-05 22:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170131115505.3f8c769b@canb.auug.org.au>
     [not found] ` <20170203092446.7e86e8af@canb.auug.org.au>
     [not found]   ` <20170202204620.75b20605@vento.lan>
     [not found]     ` <20170203095934.2bbbbf45@canb.auug.org.au>
     [not found]       ` <20170202212440.5e514ebc@vento.lan>
     [not found]         ` <20170203110117.4a0c5628@canb.auug.org.au>
     [not found]           ` <20170202222435.2798402e@vento.lan>
     [not found]             ` <20170206091914.56836dd3@canb.auug.org.au>
2017-02-05 22:22               ` linux-next: build failure after merge of the v4l-dvb tree Mauro Carvalho Chehab
     [not found] <20121112110935.eee5f582f16ab07c9faeabb1@canb.auug.org.au>
2012-11-13 13:14 ` Mauro Carvalho Chehab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).