From: Sean Young <sean@mess.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Mauro Carvalho Chehab" <mchehab@s-opensource.com>,
"Antti Seppälä" <a.seppala@gmail.com>,
"James Hogan" <james@albanarts.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: rc: nuvoton: fix deadlock in nvt_write_wakeup_codes
Date: Mon, 13 Feb 2017 11:36:23 +0000 [thread overview]
Message-ID: <20170213113623.GA17301@gofer.mess.org> (raw)
In-Reply-To: <3bf59b6c-f4be-1653-4f84-8668cf8581a1@gmail.com>
Hi Heiner,
On Sun, Feb 12, 2017 at 06:01:22PM +0100, Heiner Kallweit wrote:
> nvt_write_wakeup_codes acquires the same lock as the ISR but doesn't
> disable interrupts on the local CPU. This caused the following
> deadlock. Fix this by using spin_lock_irqsave.
>
> [ 432.362008] ================================
> [ 432.362074] WARNING: inconsistent lock state
> [ 432.362144] 4.10.0-rc7-next-20170210 #1 Not tainted
> [ 432.362219] --------------------------------
-snip-
Thank you for that, I'll make a pull request soon so we have it for 4.11.
Would you mind testing the new wakeup_protocols interface on the nuvoton
please?
cd /sys/class/rc/rc0
echo rc-5 > wakeup_protocols
echo 0xffff > wakeup_filter_mask
echo 0x1e01 > wakeup_filter
(replace as needed)
Thanks!
Sean
prev parent reply other threads:[~2017-02-13 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 17:01 [PATCH] media: rc: nuvoton: fix deadlock in nvt_write_wakeup_codes Heiner Kallweit
2017-02-13 11:36 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213113623.GA17301@gofer.mess.org \
--to=sean@mess.org \
--cc=a.seppala@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=james@albanarts.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox