* [bug report] [media] st-delta: add mjpeg support
@ 2017-02-13 19:07 Dan Carpenter
2017-02-21 9:14 ` Hugues FRUCHET
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2017-02-13 19:07 UTC (permalink / raw)
To: hugues.fruchet; +Cc: linux-media
Hello Hugues Fruchet,
The patch 433ff5b4a29b: "[media] st-delta: add mjpeg support" from
Feb 2, 2017, leads to the following static checker warning:
drivers/media/platform/sti/delta/delta-mjpeg-dec.c:415 delta_mjpeg_decode()
error: uninitialized symbol 'data_offset'.
drivers/media/platform/sti/delta/delta-mjpeg-dec.c
378 unsigned int data_offset;
^^^^^^^^^^^
379 struct mjpeg_header *header = &ctx->header_struct;
380
381 if (!ctx->header) {
382 ret = delta_mjpeg_read_header(pctx, au.vaddr, au.size,
383 header, &data_offset);
^^^^^^^^^^^
It's not immediately clear that "data_offset" must be set on the
success path.
384 if (ret) {
385 pctx->stream_errors++;
386 goto err;
387 }
388 if (header->frame_width * header->frame_height >
389 DELTA_MJPEG_MAX_RESO) {
390 dev_err(delta->dev,
391 "%s stream resolution too large: %dx%d > %d pixels budget\n",
392 pctx->name,
393 header->frame_width,
394 header->frame_height, DELTA_MJPEG_MAX_RESO);
395 ret = -EINVAL;
396 goto err;
397 }
398 ctx->header = header;
399 goto out;
400 }
401
402 if (!ctx->ipc_hdl) {
403 ret = delta_mjpeg_ipc_open(pctx);
404 if (ret)
405 goto err;
406 }
407
408 ret = delta_mjpeg_read_header(pctx, au.vaddr, au.size,
409 ctx->header, &data_offset);
410 if (ret) {
411 pctx->stream_errors++;
412 goto err;
413 }
414
415 au.paddr += data_offset;
^^^^^^^^^^^^^^^^^^^^^^^
416 au.vaddr += data_offset;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [bug report] [media] st-delta: add mjpeg support
2017-02-13 19:07 [bug report] [media] st-delta: add mjpeg support Dan Carpenter
@ 2017-02-21 9:14 ` Hugues FRUCHET
0 siblings, 0 replies; 2+ messages in thread
From: Hugues FRUCHET @ 2017-02-21 9:14 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-media@vger.kernel.org
Thanks Dan,
Patch sent to fix warning:
https://www.spinics.net/lists/linux-media/msg111529.html
BR,
Hugues.
On 02/13/2017 08:07 PM, Dan Carpenter wrote:
> Hello Hugues Fruchet,
>
> The patch 433ff5b4a29b: "[media] st-delta: add mjpeg support" from
> Feb 2, 2017, leads to the following static checker warning:
>
> drivers/media/platform/sti/delta/delta-mjpeg-dec.c:415 delta_mjpeg_decode()
> error: uninitialized symbol 'data_offset'.
>
> drivers/media/platform/sti/delta/delta-mjpeg-dec.c
> 378 unsigned int data_offset;
> ^^^^^^^^^^^
> 379 struct mjpeg_header *header = &ctx->header_struct;
> 380
> 381 if (!ctx->header) {
> 382 ret = delta_mjpeg_read_header(pctx, au.vaddr, au.size,
> 383 header, &data_offset);
> ^^^^^^^^^^^
> It's not immediately clear that "data_offset" must be set on the
> success path.
>
> 384 if (ret) {
> 385 pctx->stream_errors++;
> 386 goto err;
> 387 }
> 388 if (header->frame_width * header->frame_height >
> 389 DELTA_MJPEG_MAX_RESO) {
> 390 dev_err(delta->dev,
> 391 "%s stream resolution too large: %dx%d > %d pixels budget\n",
> 392 pctx->name,
> 393 header->frame_width,
> 394 header->frame_height, DELTA_MJPEG_MAX_RESO);
> 395 ret = -EINVAL;
> 396 goto err;
> 397 }
> 398 ctx->header = header;
> 399 goto out;
> 400 }
> 401
> 402 if (!ctx->ipc_hdl) {
> 403 ret = delta_mjpeg_ipc_open(pctx);
> 404 if (ret)
> 405 goto err;
> 406 }
> 407
> 408 ret = delta_mjpeg_read_header(pctx, au.vaddr, au.size,
> 409 ctx->header, &data_offset);
> 410 if (ret) {
> 411 pctx->stream_errors++;
> 412 goto err;
> 413 }
> 414
> 415 au.paddr += data_offset;
> ^^^^^^^^^^^^^^^^^^^^^^^
> 416 au.vaddr += data_offset;
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-21 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-13 19:07 [bug report] [media] st-delta: add mjpeg support Dan Carpenter
2017-02-21 9:14 ` Hugues FRUCHET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox