public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] siano: make it work again with CONFIG_VMAP_STACK
Date: Tue, 14 Feb 2017 17:45:57 -0200	[thread overview]
Message-ID: <20170214174557.4d7b2100@vento.lan> (raw)
In-Reply-To: <20170214194146.GA28566@kroah.com>

Em Tue, 14 Feb 2017 11:41:46 -0800
Greg KH <gregkh@linuxfoundation.org> escreveu:

> On Tue, Feb 14, 2017 at 05:32:11PM -0200, Mauro Carvalho Chehab wrote:
> > Reported as a Kaffeine bug:
> > 	https://bugs.kde.org/show_bug.cgi?id=375811
> > 
> > The USB control messages require DMA to work. We cannot pass
> > a stack-allocated buffer, as it is not warranted that the
> > stack would be into a DMA enabled area.
> > 
> > On Kernel 4.9, the default is to not accept DMA on stack anymore.
> > 
> > Tested with USB ID 2040:5510: Hauppauge Windham
> > 
> > Cc: stable@vger.kernel.org # For 4.9+  
> 
> Unless there is some major reason, this should go into _all_ stable
> releases, as the driver would be broken on them all for platforms that
> can't handle USB data that is not DMA-able.  This has been a requirement
> for USB drivers since the 2.2 days.

Good point! No, there's no particular reason why not backporting it
to older Kernel releases. I suspect that this particular part of
the driver hasn't changed for a while. So, it can very likely be
backported to all stable releases.

I'll fix the C/C message when submitting it upstream.

Thanks,
Mauro

      reply	other threads:[~2017-02-14 19:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 19:32 [PATCH] siano: make it work again with CONFIG_VMAP_STACK Mauro Carvalho Chehab
2017-02-14 19:41 ` Greg KH
2017-02-14 19:45   ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170214174557.4d7b2100@vento.lan \
    --to=mchehab@s-opensource.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mchehab@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox