From: Jonathan Sims <jonathan.625266@earthlink.net>
To: linux-media@vger.kernel.org, hverkuil@xs4all.nl,
mchehab@kernel.org, kpyle@austin.rr.com, ryleyjangus@gmail.com
Subject: [PATCH 1/1] hdpvr: code cleanup
Date: Tue, 14 Feb 2017 20:18:32 -0500 [thread overview]
Message-ID: <20170214201832.7a418b5a@earthlink.net> (raw)
This is a code cleanup after recent changes introduced by commit a503ff812430e104f591287b512aa4e3a83f20b1.
Signed-off-by: Jonathan Sims <jonathan.625266@earthlink.net>
---
drivers/media/usb/hdpvr/hdpvr-video.c | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c
index 7fb036d6a86e..b2ce5c0807fb 100644
--- a/drivers/media/usb/hdpvr/hdpvr-video.c
+++ b/drivers/media/usb/hdpvr/hdpvr-video.c
@@ -449,7 +449,7 @@ static ssize_t hdpvr_read(struct file *file, char __user *buffer, size_t count,
if (buf->status != BUFSTAT_READY &&
dev->status != STATUS_DISCONNECTED) {
- int err;
+
/* return nonblocking */
if (file->f_flags & O_NONBLOCK) {
if (!ret)
@@ -457,23 +457,19 @@ static ssize_t hdpvr_read(struct file *file, char
__user *buffer, size_t count, goto err;
}
- err =
wait_event_interruptible_timeout(dev->wait_data,
+ ret =
wait_event_interruptible_timeout(dev->wait_data, buf->status ==
BUFSTAT_READY, msecs_to_jiffies(1000));
- if (err < 0) {
- ret = err;
+ if (ret < 0)
goto err;
- }
- if (!err) {
+ if (!ret) {
v4l2_dbg(MSG_INFO, hdpvr_debug,
&dev->v4l2_dev, "timeout: restart streaming\n");
hdpvr_stop_streaming(dev);
- msecs_to_jiffies(4000);
- err = hdpvr_start_streaming(dev);
- if (err) {
- ret = err;
+ msleep(4000);
+ ret = hdpvr_start_streaming(dev);
+ if (ret)
goto err;
- }
}
}
--
2.11.1
next reply other threads:[~2017-02-15 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 1:18 Jonathan Sims [this message]
2017-02-19 23:40 ` [PATCH 1/1] hdpvr: code cleanup Keith Pyle
2017-03-06 11:14 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214201832.7a418b5a@earthlink.net \
--to=jonathan.625266@earthlink.net \
--cc=hverkuil@xs4all.nl \
--cc=kpyle@austin.rr.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ryleyjangus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox