From: Peter Senna Tschudin <peter.senna@gmail.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] media: pci: saa7164: remove dead code
Date: Tue, 21 Feb 2017 23:05:17 +0100 [thread overview]
Message-ID: <20170221220517.GA13525@gmail.com> (raw)
In-Reply-To: <20170221034959.GA4837@embeddedgus>
On Mon, Feb 20, 2017 at 09:49:59PM -0600, Gustavo A. R. Silva wrote:
> Remove dead code. The following line of code is never reached:
> return SAA_OK;
>
> Addresses-Coverity-ID: 114283
Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/media/pci/saa7164/saa7164-cmd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/pci/saa7164/saa7164-cmd.c b/drivers/media/pci/saa7164/saa7164-cmd.c
> index 169c90a..fb19498 100644
> --- a/drivers/media/pci/saa7164/saa7164-cmd.c
> +++ b/drivers/media/pci/saa7164/saa7164-cmd.c
> @@ -181,8 +181,6 @@ static int saa7164_cmd_dequeue(struct saa7164_dev *dev)
> wake_up(q);
> return SAA_OK;
> }
> -
> - return SAA_OK;
> }
>
> static int saa7164_cmd_set(struct saa7164_dev *dev, struct tmComResInfo *msg,
> --
> 2.5.0
>
next prev parent reply other threads:[~2017-02-21 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 3:46 [PATCH 1/2] media: pci: saa7164: remove unnecessary code Gustavo A. R. Silva
2017-02-21 3:49 ` [PATCH 2/2] media: pci: saa7164: remove dead code Gustavo A. R. Silva
2017-02-21 22:05 ` Peter Senna Tschudin [this message]
2017-02-21 22:07 ` [PATCH 1/2] media: pci: saa7164: remove unnecessary code Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221220517.GA13525@gmail.com \
--to=peter.senna@gmail.com \
--cc=garsilva@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).