* [PATCH 1/2] media: pci: saa7164: remove unnecessary code
@ 2017-02-21 3:46 Gustavo A. R. Silva
2017-02-21 3:49 ` [PATCH 2/2] media: pci: saa7164: remove dead code Gustavo A. R. Silva
2017-02-21 22:07 ` [PATCH 1/2] media: pci: saa7164: remove unnecessary code Peter Senna Tschudin
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-02-21 3:46 UTC (permalink / raw)
To: mchehab
Cc: linux-media, linux-kernel, Gustavo A. R. Silva,
Peter Senna Tschudin
Remove unnecessary variable 'loop'.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/media/pci/saa7164/saa7164-cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/pci/saa7164/saa7164-cmd.c b/drivers/media/pci/saa7164/saa7164-cmd.c
index 45951b3..169c90a 100644
--- a/drivers/media/pci/saa7164/saa7164-cmd.c
+++ b/drivers/media/pci/saa7164/saa7164-cmd.c
@@ -134,14 +134,13 @@ int saa7164_irq_dequeue(struct saa7164_dev *dev)
* -bus/c running buffer. */
static int saa7164_cmd_dequeue(struct saa7164_dev *dev)
{
- int loop = 1;
int ret;
u32 timeout;
wait_queue_head_t *q = NULL;
u8 tmp[512];
dprintk(DBGLVL_CMD, "%s()\n", __func__);
- while (loop) {
+ while (true) {
struct tmComResInfo tRsp = { 0, 0, 0, 0, 0, 0 };
ret = saa7164_bus_get(dev, &tRsp, NULL, 1);
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] media: pci: saa7164: remove dead code
2017-02-21 3:46 [PATCH 1/2] media: pci: saa7164: remove unnecessary code Gustavo A. R. Silva
@ 2017-02-21 3:49 ` Gustavo A. R. Silva
2017-02-21 22:05 ` Peter Senna Tschudin
2017-02-21 22:07 ` [PATCH 1/2] media: pci: saa7164: remove unnecessary code Peter Senna Tschudin
1 sibling, 1 reply; 4+ messages in thread
From: Gustavo A. R. Silva @ 2017-02-21 3:49 UTC (permalink / raw)
To: mchehab
Cc: linux-media, linux-kernel, Gustavo A. R. Silva,
Peter Senna Tschudin
Remove dead code. The following line of code is never reached:
return SAA_OK;
Addresses-Coverity-ID: 114283
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/media/pci/saa7164/saa7164-cmd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/pci/saa7164/saa7164-cmd.c b/drivers/media/pci/saa7164/saa7164-cmd.c
index 169c90a..fb19498 100644
--- a/drivers/media/pci/saa7164/saa7164-cmd.c
+++ b/drivers/media/pci/saa7164/saa7164-cmd.c
@@ -181,8 +181,6 @@ static int saa7164_cmd_dequeue(struct saa7164_dev *dev)
wake_up(q);
return SAA_OK;
}
-
- return SAA_OK;
}
static int saa7164_cmd_set(struct saa7164_dev *dev, struct tmComResInfo *msg,
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] media: pci: saa7164: remove dead code
2017-02-21 3:49 ` [PATCH 2/2] media: pci: saa7164: remove dead code Gustavo A. R. Silva
@ 2017-02-21 22:05 ` Peter Senna Tschudin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Senna Tschudin @ 2017-02-21 22:05 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: mchehab, linux-media, linux-kernel
On Mon, Feb 20, 2017 at 09:49:59PM -0600, Gustavo A. R. Silva wrote:
> Remove dead code. The following line of code is never reached:
> return SAA_OK;
>
> Addresses-Coverity-ID: 114283
Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/media/pci/saa7164/saa7164-cmd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/pci/saa7164/saa7164-cmd.c b/drivers/media/pci/saa7164/saa7164-cmd.c
> index 169c90a..fb19498 100644
> --- a/drivers/media/pci/saa7164/saa7164-cmd.c
> +++ b/drivers/media/pci/saa7164/saa7164-cmd.c
> @@ -181,8 +181,6 @@ static int saa7164_cmd_dequeue(struct saa7164_dev *dev)
> wake_up(q);
> return SAA_OK;
> }
> -
> - return SAA_OK;
> }
>
> static int saa7164_cmd_set(struct saa7164_dev *dev, struct tmComResInfo *msg,
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] media: pci: saa7164: remove unnecessary code
2017-02-21 3:46 [PATCH 1/2] media: pci: saa7164: remove unnecessary code Gustavo A. R. Silva
2017-02-21 3:49 ` [PATCH 2/2] media: pci: saa7164: remove dead code Gustavo A. R. Silva
@ 2017-02-21 22:07 ` Peter Senna Tschudin
1 sibling, 0 replies; 4+ messages in thread
From: Peter Senna Tschudin @ 2017-02-21 22:07 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: mchehab, linux-media, linux-kernel
On Mon, Feb 20, 2017 at 09:46:58PM -0600, Gustavo A. R. Silva wrote:
> Remove unnecessary variable 'loop'.
>
Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/media/pci/saa7164/saa7164-cmd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/pci/saa7164/saa7164-cmd.c b/drivers/media/pci/saa7164/saa7164-cmd.c
> index 45951b3..169c90a 100644
> --- a/drivers/media/pci/saa7164/saa7164-cmd.c
> +++ b/drivers/media/pci/saa7164/saa7164-cmd.c
> @@ -134,14 +134,13 @@ int saa7164_irq_dequeue(struct saa7164_dev *dev)
> * -bus/c running buffer. */
> static int saa7164_cmd_dequeue(struct saa7164_dev *dev)
> {
> - int loop = 1;
> int ret;
> u32 timeout;
> wait_queue_head_t *q = NULL;
> u8 tmp[512];
> dprintk(DBGLVL_CMD, "%s()\n", __func__);
>
> - while (loop) {
> + while (true) {
>
> struct tmComResInfo tRsp = { 0, 0, 0, 0, 0, 0 };
> ret = saa7164_bus_get(dev, &tRsp, NULL, 1);
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-21 22:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-21 3:46 [PATCH 1/2] media: pci: saa7164: remove unnecessary code Gustavo A. R. Silva
2017-02-21 3:49 ` [PATCH 2/2] media: pci: saa7164: remove dead code Gustavo A. R. Silva
2017-02-21 22:05 ` Peter Senna Tschudin
2017-02-21 22:07 ` [PATCH 1/2] media: pci: saa7164: remove unnecessary code Peter Senna Tschudin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).