public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: bill murphy <gc2majortom@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: Kaffeine commit b510bff2 won't compile
Date: Mon, 27 Feb 2017 07:11:22 -0300	[thread overview]
Message-ID: <20170227071122.3a319481@vento.lan> (raw)
In-Reply-To: <bafdb165-261c-0129-e0dc-29819a55ca43@gmail.com>

Em Sun, 26 Feb 2017 20:57:20 -0500
bill murphy <gc2majortom@gmail.com> escreveu:

> Hi,
> Can someone double check me on this?
> 
> It seems there might be a missing header,
> in the src directory, preventing the last commit from
> compiling. The commit prior compiles fine. So not that big a deal, just 
> letting folks know what I ran in to.
> 
> I don't see this file, 'log.h', anywhere in the src directory. Guessing 
> it wasn't 'added' for tracking?
> 
> git://anongit.kde.org/kaffeine
> 
> diff between master and previous commit...just a snippet, as other files 
> are including the same missing header.
> 
> diff --git a/src/dvb/dvbcam_linux.cpp b/src/dvb/dvbcam_linux.cpp
> index ceb9dbd..5c9c575 100644
> --- a/src/dvb/dvbcam_linux.cpp
> +++ b/src/dvb/dvbcam_linux.cpp
> @@ -18,11 +18,7 @@
>    * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>    */
> 
> -#include <KLocalizedString>
> -#include <QDebug>
> -#if QT_VERSION < 0x050500
> -# define qInfo qDebug
> -#endif
> +#include "../log.h"
> 
>   #include <errno.h>
>   #include <fcntl.h>
> 
> where compile complains of that missing header...
> 
> Scanning dependencies of target kaffeine
> [ 20%] Building CXX object 
> src/CMakeFiles/kaffeine.dir/dvb/dvbcam_linux.cpp.o
> /home/user/src2/kaffeine/src/dvb/dvbcam_linux.cpp:21:20: fatal error: 
> ../log.h: No such file or directory
> compilation terminated.

Thanks for complaining about it! I forgot to add src/log.h on the
commit.

You should be able to compile it now.

Thanks,
Mauro

  reply	other threads:[~2017-02-27 10:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27  1:57 Kaffeine commit b510bff2 won't compile bill murphy
2017-02-27 10:11 ` Mauro Carvalho Chehab [this message]
2017-02-28  4:46   ` bill murphy
2017-03-01 10:00     ` Mauro Carvalho Chehab
2017-03-04 13:21       ` bill murphy
2017-03-04 14:07         ` Mauro Carvalho Chehab
2017-03-04 18:57           ` bill murphy
2017-03-05  1:54             ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227071122.3a319481@vento.lan \
    --to=mchehab@s-opensource.com \
    --cc=gc2majortom@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox