Kaffeine commit b510bff2 won't compile

Kaffeine commit b510bff2 won't compile

[bill murphy]

Hi,
Can someone double check me on this?

It seems there might be a missing header,
in the src directory, preventing the last commit from
compiling. The commit prior compiles fine. So not that big a deal, just 
letting folks know what I ran in to.

I don't see this file, 'log.h', anywhere in the src directory. Guessing 
it wasn't 'added' for tracking?

git://anongit.kde.org/kaffeine

diff between master and previous commit...just a snippet, as other files 
are including the same missing header.

diff --git a/src/dvb/dvbcam_linux.cpp b/src/dvb/dvbcam_linux.cpp
index ceb9dbd..5c9c575 100644
--- a/src/dvb/dvbcam_linux.cpp
+++ b/src/dvb/dvbcam_linux.cpp
@@ -18,11 +18,7 @@
   * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
   */

-#include <KLocalizedString>
-#include <QDebug>
-#if QT_VERSION < 0x050500
-# define qInfo qDebug
-#endif
+#include "../log.h"

  #include <errno.h>
  #include <fcntl.h>

where compile complains of that missing header...

Scanning dependencies of target kaffeine
[ 20%] Building CXX object 
src/CMakeFiles/kaffeine.dir/dvb/dvbcam_linux.cpp.o
/home/user/src2/kaffeine/src/dvb/dvbcam_linux.cpp:21:20: fatal error: 
../log.h: No such file or directory
compilation terminated.

Regards,

Bill

Re: Kaffeine commit b510bff2 won't compile

[Mauro Carvalho Chehab]

Em Sun, 26 Feb 2017 20:57:20 -0500
bill murphy <gc2majortom@gmail.com> escreveu:

> Hi,
> Can someone double check me on this?
> 
> It seems there might be a missing header,
> in the src directory, preventing the last commit from
> compiling. The commit prior compiles fine. So not that big a deal, just 
> letting folks know what I ran in to.
> 
> I don't see this file, 'log.h', anywhere in the src directory. Guessing 
> it wasn't 'added' for tracking?
> 
> git://anongit.kde.org/kaffeine
> 
> diff between master and previous commit...just a snippet, as other files 
> are including the same missing header.
> 
> diff --git a/src/dvb/dvbcam_linux.cpp b/src/dvb/dvbcam_linux.cpp
> index ceb9dbd..5c9c575 100644
> --- a/src/dvb/dvbcam_linux.cpp
> +++ b/src/dvb/dvbcam_linux.cpp
> @@ -18,11 +18,7 @@
>    * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>    */
> 
> -#include <KLocalizedString>
> -#include <QDebug>
> -#if QT_VERSION < 0x050500
> -# define qInfo qDebug
> -#endif
> +#include "../log.h"
> 
>   #include <errno.h>
>   #include <fcntl.h>
> 
> where compile complains of that missing header...
> 
> Scanning dependencies of target kaffeine
> [ 20%] Building CXX object 
> src/CMakeFiles/kaffeine.dir/dvb/dvbcam_linux.cpp.o
> /home/user/src2/kaffeine/src/dvb/dvbcam_linux.cpp:21:20: fatal error: 
> ../log.h: No such file or directory
> compilation terminated.

Thanks for complaining about it! I forgot to add src/log.h on the
commit.

You should be able to compile it now.

Thanks,
Mauro

Re: Kaffeine commit b510bff2 won't compile

[bill murphy]

Hi Mauro,

Thanks for looking in to it. All is well now.

On a sidenote, given 700 MHz is used for LTE, and not broadcasting

anymore, would you folks consider removing ch 52 thru 69

in the us-atsc-frequencies if I posted a simple patch to dtv-scan-tables?


Bill

On 02/27/2017 05:11 AM, Mauro Carvalho Chehab wrote:
> Em Sun, 26 Feb 2017 20:57:20 -0500
> bill murphy <gc2majortom@gmail.com> escreveu:
>
>> Hi,
>> Can someone double check me on this?
>>
>> It seems there might be a missing header,
>> in the src directory, preventing the last commit from
>> compiling. The commit prior compiles fine. So not that big a deal, just
>> letting folks know what I ran in to.
>>
>> I don't see this file, 'log.h', anywhere in the src directory. Guessing
>> it wasn't 'added' for tracking?
>>
>> git://anongit.kde.org/kaffeine
>>
>> diff between master and previous commit...just a snippet, as other files
>> are including the same missing header.
>>
>> diff --git a/src/dvb/dvbcam_linux.cpp b/src/dvb/dvbcam_linux.cpp
>> index ceb9dbd..5c9c575 100644
>> --- a/src/dvb/dvbcam_linux.cpp
>> +++ b/src/dvb/dvbcam_linux.cpp
>> @@ -18,11 +18,7 @@
>>     * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>>     */
>>
>> -#include <KLocalizedString>
>> -#include <QDebug>
>> -#if QT_VERSION < 0x050500
>> -# define qInfo qDebug
>> -#endif
>> +#include "../log.h"
>>
>>    #include <errno.h>
>>    #include <fcntl.h>
>>
>> where compile complains of that missing header...
>>
>> Scanning dependencies of target kaffeine
>> [ 20%] Building CXX object
>> src/CMakeFiles/kaffeine.dir/dvb/dvbcam_linux.cpp.o
>> /home/user/src2/kaffeine/src/dvb/dvbcam_linux.cpp:21:20: fatal error:
>> ../log.h: No such file or directory
>> compilation terminated.
> Thanks for complaining about it! I forgot to add src/log.h on the
> commit.
>
> You should be able to compile it now.
>
> Thanks,
> Mauro

Re: Kaffeine commit b510bff2 won't compile

[Mauro Carvalho Chehab]

Hi Bill,

Em Mon, 27 Feb 2017 23:46:09 -0500
bill murphy <gc2majortom@gmail.com> escreveu:

> Hi Mauro,
> 
> Thanks for looking in to it. All is well now.

Good! Thanks for testing.

> On a sidenote, given 700 MHz is used for LTE, and not broadcasting
> 
> anymore, would you folks consider removing ch 52 thru 69
> 
> in the us-atsc-frequencies if I posted a simple patch to dtv-scan-tables?

The problem is that, despite its name, this table is used on other
Countries using atsc (like Mexico, Canada and South Korea):

	https://en.wikipedia.org/wiki/List_of_digital_television_deployments_by_country#/media/File:Digital_broadcast_standards.svg

So, while the 700 MHz are still used on other ATSC Countries, we can't
remove, as otherwise, it will not discover the channels at the upper
frequency range there.

Regards,
Mauro

Re: Kaffeine commit b510bff2 won't compile

[bill murphy]

Hi Mauro,

yes I can appreciate that, but why not just make one file for each 
country that actually differs,

rather than make the rest of us suffer?

canada and the us are the same.

atsc/us-ATSC-center-frequencies-8VSB

So could add two files for mexico and korea.

atsc/mx-ATSC-center-frequencies-8VSB
atsc/kr-ATSC-center-frequencies-8VSB

can't be any worse that the hundreds of files being maintained for DVB-T 
in various countries.


On 03/01/2017 05:00 AM, Mauro Carvalho Chehab wrote:
> Hi Bill,
>
> Em Mon, 27 Feb 2017 23:46:09 -0500
> bill murphy <gc2majortom@gmail.com> escreveu:
>
>> Hi Mauro,
>>
>> Thanks for looking in to it. All is well now.
> Good! Thanks for testing.
>
>> On a sidenote, given 700 MHz is used for LTE, and not broadcasting
>>
>> anymore, would you folks consider removing ch 52 thru 69
>>
>> in the us-atsc-frequencies if I posted a simple patch to dtv-scan-tables?
> The problem is that, despite its name, this table is used on other
> Countries using atsc (like Mexico, Canada and South Korea):
>
> 	https://en.wikipedia.org/wiki/List_of_digital_television_deployments_by_country#/media/File:Digital_broadcast_standards.svg
>
> So, while the 700 MHz are still used on other ATSC Countries, we can't
> remove, as otherwise, it will not discover the channels at the upper
> frequency range there.
>
> Regards,
> Mauro

Re: Kaffeine commit b510bff2 won't compile

[Mauro Carvalho Chehab]

Em Sat, 4 Mar 2017 08:21:51 -0500
bill murphy <gc2majortom@gmail.com> escreveu:

> Hi Mauro,
> 
> yes I can appreciate that, but why not just make one file for each 
> country that actually differs,
> 
> rather than make the rest of us suffer?
> 
> canada and the us are the same.
> 
> atsc/us-ATSC-center-frequencies-8VSB
> 
> So could add two files for mexico and korea.
> 
> atsc/mx-ATSC-center-frequencies-8VSB
> atsc/kr-ATSC-center-frequencies-8VSB
> 
> can't be any worse that the hundreds of files being maintained for DVB-T 
> in various countries.

That could be done, but newer updates to dtv-scan-tables
(and projects that use it, like Kaffeine) would have regressions for
people outside US that use it.

What could be done, instead, would be to have another file for
US new frequency set.

> 
> 
> On 03/01/2017 05:00 AM, Mauro Carvalho Chehab wrote:
> > Hi Bill,
> >
> > Em Mon, 27 Feb 2017 23:46:09 -0500
> > bill murphy <gc2majortom@gmail.com> escreveu:
> >  
> >> Hi Mauro,
> >>
> >> Thanks for looking in to it. All is well now.  
> > Good! Thanks for testing.
> >  
> >> On a sidenote, given 700 MHz is used for LTE, and not broadcasting
> >>
> >> anymore, would you folks consider removing ch 52 thru 69
> >>
> >> in the us-atsc-frequencies if I posted a simple patch to dtv-scan-tables?  
> > The problem is that, despite its name, this table is used on other
> > Countries using atsc (like Mexico, Canada and South Korea):
> >
> > 	https://en.wikipedia.org/wiki/List_of_digital_television_deployments_by_country#/media/File:Digital_broadcast_standards.svg
> >
> > So, while the 700 MHz are still used on other ATSC Countries, we can't
> > remove, as otherwise, it will not discover the channels at the upper
> > frequency range there.
> >
> > Regards,
> > Mauro  
> 



Thanks,
Mauro

Re: Kaffeine commit b510bff2 won't compile

[bill murphy]

That sounds good, would you like me to submit a good Frequency List to 'dtv-scan-tables'?
Maybe name it something like 'atsc/us-ATSC-center-frequencies-8VSB-06-2009', reflecting the
date since the spectrum was allocated that way?

Another Kaffeine related issue, I noticed in libdbv5 of v4l-utils, that there is no
"North American Standard" LNB configuration. I just modified the source to add
add one and recompiled. Since in North America, the FSS Band is from 11700 to 12200, and our LNBs are
designed with an LO Frequency of 10750 MHz. Kaffeine seems to work correctly now on my
Ku Band antennas. Would you like me to submit the patch, or just create a new bug report?

Thanks again,
Bill


On 03/04/2017 09:07 AM, Mauro Carvalho Chehab wrote:
> Em Sat, 4 Mar 2017 08:21:51 -0500
> bill murphy <gc2majortom@gmail.com> escreveu:
>
>> Hi Mauro,
>>
>> yes I can appreciate that, but why not just make one file for each
>> country that actually differs,
>>
>> rather than make the rest of us suffer?
>>
>> canada and the us are the same.
>>
>> atsc/us-ATSC-center-frequencies-8VSB
>>
>> So could add two files for mexico and korea.
>>
>> atsc/mx-ATSC-center-frequencies-8VSB
>> atsc/kr-ATSC-center-frequencies-8VSB
>>
>> can't be any worse that the hundreds of files being maintained for DVB-T
>> in various countries.
> That could be done, but newer updates to dtv-scan-tables
> (and projects that use it, like Kaffeine) would have regressions for
> people outside US that use it.
>
> What could be done, instead, would be to have another file for
> US new frequency set.
>
>>
>> On 03/01/2017 05:00 AM, Mauro Carvalho Chehab wrote:
>>> Hi Bill,
>>>
>>> Em Mon, 27 Feb 2017 23:46:09 -0500
>>> bill murphy <gc2majortom@gmail.com> escreveu:
>>>   
>>>> Hi Mauro,
>>>>
>>>> Thanks for looking in to it. All is well now.
>>> Good! Thanks for testing.
>>>   
>>>> On a sidenote, given 700 MHz is used for LTE, and not broadcasting
>>>>
>>>> anymore, would you folks consider removing ch 52 thru 69
>>>>
>>>> in the us-atsc-frequencies if I posted a simple patch to dtv-scan-tables?
>>> The problem is that, despite its name, this table is used on other
>>> Countries using atsc (like Mexico, Canada and South Korea):
>>>
>>> 	https://en.wikipedia.org/wiki/List_of_digital_television_deployments_by_country#/media/File:Digital_broadcast_standards.svg
>>>
>>> So, while the 700 MHz are still used on other ATSC Countries, we can't
>>> remove, as otherwise, it will not discover the channels at the upper
>>> frequency range there.
>>>
>>> Regards,
>>> Mauro
>
>
> Thanks,
> Mauro

Re: Kaffeine commit b510bff2 won't compile

[Mauro Carvalho Chehab]

Em Sat, 4 Mar 2017 13:57:28 -0500
bill murphy <gc2majortom@gmail.com> escreveu:

> That sounds good, would you like me to submit a good Frequency List to 'dtv-scan-tables'?

Yes, please.

> Maybe name it something like 'atsc/us-ATSC-center-frequencies-8VSB-06-2009', reflecting the
> date since the spectrum was allocated that way?

Yeah, that would work.

> Another Kaffeine related issue, I noticed in libdbv5 of v4l-utils, that there is no
> "North American Standard" LNB configuration. I just modified the source to add
> add one and recompiled. Since in North America, the FSS Band is from 11700 to 12200, and our LNBs are
> designed with an LO Frequency of 10750 MHz. Kaffeine seems to work correctly now on my
> Ku Band antennas. Would you like me to submit the patch, or just create a new bug report?

Better to submit a patch. You should notice, however, that it may have
more than one LNBf type in US. So, you need to take some care when
assigning a name for the LNBf.

> 
> Thanks again,
> Bill
> 
> 
> On 03/04/2017 09:07 AM, Mauro Carvalho Chehab wrote:
> > Em Sat, 4 Mar 2017 08:21:51 -0500
> > bill murphy <gc2majortom@gmail.com> escreveu:
> >  
> >> Hi Mauro,
> >>
> >> yes I can appreciate that, but why not just make one file for each
> >> country that actually differs,
> >>
> >> rather than make the rest of us suffer?
> >>
> >> canada and the us are the same.
> >>
> >> atsc/us-ATSC-center-frequencies-8VSB
> >>
> >> So could add two files for mexico and korea.
> >>
> >> atsc/mx-ATSC-center-frequencies-8VSB
> >> atsc/kr-ATSC-center-frequencies-8VSB
> >>
> >> can't be any worse that the hundreds of files being maintained for DVB-T
> >> in various countries.  
> > That could be done, but newer updates to dtv-scan-tables
> > (and projects that use it, like Kaffeine) would have regressions for
> > people outside US that use it.
> >
> > What could be done, instead, would be to have another file for
> > US new frequency set.
> >  
> >>
> >> On 03/01/2017 05:00 AM, Mauro Carvalho Chehab wrote:  
> >>> Hi Bill,
> >>>
> >>> Em Mon, 27 Feb 2017 23:46:09 -0500
> >>> bill murphy <gc2majortom@gmail.com> escreveu:
> >>>     
> >>>> Hi Mauro,
> >>>>
> >>>> Thanks for looking in to it. All is well now.  
> >>> Good! Thanks for testing.
> >>>     
> >>>> On a sidenote, given 700 MHz is used for LTE, and not broadcasting
> >>>>
> >>>> anymore, would you folks consider removing ch 52 thru 69
> >>>>
> >>>> in the us-atsc-frequencies if I posted a simple patch to dtv-scan-tables?  
> >>> The problem is that, despite its name, this table is used on other
> >>> Countries using atsc (like Mexico, Canada and South Korea):
> >>>
> >>> 	https://en.wikipedia.org/wiki/List_of_digital_television_deployments_by_country#/media/File:Digital_broadcast_standards.svg
> >>>
> >>> So, while the 700 MHz are still used on other ATSC Countries, we can't
> >>> remove, as otherwise, it will not discover the channels at the upper
> >>> frequency range there.
> >>>
> >>> Regards,
> >>> Mauro  
> >
> >
> > Thanks,
> > Mauro  
> 



Thanks,
Mauro