From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Wu, Songjun" <Songjun.Wu@microchip.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [bug report] [media] atmel-isc: add the isc pipeline function
Date: Wed, 8 Mar 2017 07:38:14 +0300 [thread overview]
Message-ID: <20170308043814.GD4120@mwanda> (raw)
In-Reply-To: <dbe0c888-815d-b981-a9c9-9c7283e81ee0@microchip.com>
No. Imagine the v4l2_subdev_call() loop exits with "fmt" set to NULL.
It will cause a crash.
Please re-read my original email because I think you may have meant to
reset fmt after that loop.
regards,
dan carpenter
next prev parent reply other threads:[~2017-03-08 4:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 0:17 [bug report] [media] atmel-isc: add the isc pipeline function Dan Carpenter
2017-03-08 3:01 ` Wu, Songjun
2017-03-08 4:38 ` Dan Carpenter [this message]
2017-03-08 5:06 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308043814.GD4120@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Songjun.Wu@microchip.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox