* [patch] staging/atomisp: silence uninitialized variable warnings
@ 2017-03-14 7:51 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-03-14 7:51 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Alan Cox
Cc: Greg Kroah-Hartman, linux-media, devel, kernel-janitors
These print an uninitialized value for "opt". Let's just remove the
printk.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c
index 327a5c535fab..7f7c6d5133d2 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c
@@ -128,11 +128,9 @@ static ssize_t iunit_dbgfun_store(struct device_driver *drv, const char *buf,
unsigned int opt;
int ret;
- if (kstrtouint(buf, 10, &opt)) {
- dev_err(atomisp_dev, "%s setting %d value invalid\n",
- __func__, opt);
- return -EINVAL;
- }
+ ret = kstrtouint(buf, 10, &opt);
+ if (ret)
+ return ret;
ret = atomisp_set_css_dbgfunc(iunit_debug.isp, opt);
if (ret)
@@ -154,11 +152,9 @@ static ssize_t iunit_dbgopt_store(struct device_driver *drv, const char *buf,
unsigned int opt;
int ret;
- if (kstrtouint(buf, 10, &opt)) {
- dev_err(atomisp_dev, "%s setting %d value invalid\n",
- __func__, opt);
- return -EINVAL;
- }
+ ret = kstrtouint(buf, 10, &opt);
+ if (ret)
+ return ret;
iunit_debug.dbgopt = opt;
ret = iunit_dump_dbgopt(iunit_debug.isp, iunit_debug.dbgopt);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-14 7:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-14 7:51 [patch] staging/atomisp: silence uninitialized variable warnings Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).