linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] staging: atomisp: missing break statement in switch
@ 2017-03-14  7:52 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-03-14  7:52 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Alan Cox
  Cc: Greg Kroah-Hartman, Varsha Rao, linux-media, devel,
	kernel-janitors

Static analysis tools suggest that we probably want a break statement
here before then next cast statement.  Looks true to me.

Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
index e3d4d0e0ed9c..ac7598291b95 100644
--- a/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
+++ b/drivers/staging/media/atomisp/i2c/ov5693/ov5693.c
@@ -1132,7 +1132,7 @@ static int ov5693_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
 		break;
 	case V4L2_CID_FOCUS_STATUS:
 		ret = ov5693_q_focus_status(&dev->sd, &ctrl->val);
-
+		break;
 	case V4L2_CID_BIN_FACTOR_HORZ:
 		ret = ov5693_g_bin_factor_x(&dev->sd, &ctrl->val);
 		break;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-14  7:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-14  7:52 [patch] staging: atomisp: missing break statement in switch Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).