* [PATCH] Staging: atomisp: fix locking in alloc_user_pages()
@ 2017-03-17 20:42 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-03-17 20:42 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Alan Cox
Cc: Greg Kroah-Hartman, linux-media, devel, kernel-janitors
We call this function with the lock held and should also return with the
lock held as well. This one error path is not-consistent because we
should return without the lock held.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
index fd3bd5c48672..d1a609d25f18 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
@@ -1012,6 +1012,7 @@ static int alloc_user_pages(struct hmm_buffer_object *bo,
dev_err(atomisp_dev, "find_vma failed\n");
atomisp_kernel_free(bo->page_obj);
atomisp_kernel_free(pages);
+ mutex_lock(&bo->mutex);
return -EFAULT;
}
mutex_lock(&bo->mutex);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-17 20:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-17 20:42 [PATCH] Staging: atomisp: fix locking in alloc_user_pages() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).