* [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
@ 2017-03-20 11:02 unknown
2017-03-20 11:57 ` Dan Carpenter
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: unknown @ 2017-03-20 11:02 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media, devel,
linux-kernel
Signed-off-by: Eddie Youseph <psyblasted@gmail.com>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +++++++++++++--------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index d605c41..7d33bce 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2020,27 +2020,27 @@ static irqreturn_t bcm2048_handler(int irq, void *dev)
return count; \
}
-DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
-
-DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
-
-DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
+
+DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
+
+DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)
property_read(rds_pi, unsigned int, "%x")
property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
@@ -2052,7 +2052,7 @@ static irqreturn_t bcm2048_handler(int irq, void *dev)
property_read(region_top_frequency, unsigned int, "%u")
property_signed_read(fm_carrier_error, int, "%d")
property_signed_read(fm_rssi, int, "%d")
-DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
static struct device_attribute attrs[] = {
__ATTR(power_state, 0644, bcm2048_power_state_read,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
2017-03-20 11:02 [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' unknown
@ 2017-03-20 11:57 ` Dan Carpenter
2017-03-20 12:05 ` Dan Carpenter
2017-03-21 3:54 ` kbuild test robot
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-03-20 11:57 UTC (permalink / raw)
To: unknown
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media, devel,
linux-kernel
The subject is too long.
On Mon, Mar 20, 2017 at 10:02:33PM +1100, unknown wrote:
> Signed-off-by: Eddie Youseph <psyblasted@gmail.com>
You need to have a changelog.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
2017-03-20 11:02 [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' unknown
2017-03-20 11:57 ` Dan Carpenter
@ 2017-03-20 12:05 ` Dan Carpenter
2017-03-21 3:54 ` kbuild test robot
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-03-20 12:05 UTC (permalink / raw)
To: unknown
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media, devel,
linux-kernel
Also fix your From header.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
2017-03-20 11:02 [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' unknown
2017-03-20 11:57 ` Dan Carpenter
2017-03-20 12:05 ` Dan Carpenter
@ 2017-03-21 3:54 ` kbuild test robot
2 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2017-03-21 3:54 UTC (permalink / raw)
To: unknown
Cc: kbuild-all, Mauro Carvalho Chehab, Greg Kroah-Hartman,
linux-media, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 8107 bytes --]
Hi unknown,
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.11-rc3 next-20170320]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/unknown/staging-radio-bcm2048-Fix-checkpatch-warnings-WARNING-Prefer-unsigned-int-to-bare-use-of-unsigned/20170321-105721
base: git://linuxtv.org/media_tree.git master
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All errors (new ones prefixed by >>):
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_power_state_write':
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2031:50: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2031:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_mute_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2032:43: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2032:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_audio_route_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2033:50: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2033:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_dac_output_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2034:49: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2034:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_hi_lo_injection_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2036:57: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2036:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_frequency_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2037:51: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2037:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_af_frequency_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2038:54: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2038:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_deemphasis_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2039:52: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2039:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_rds_mask_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2040:50: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2040:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_best_tune_mode_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2041:56: error: two or more data types in declaration specifiers
DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c:1951:2: note: in definition of macro 'property_write'
type value; \
^
drivers/staging/media/bcm2048/radio-bcm2048.c:2041:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
^
drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_search_rssi_threshold_write':
drivers/staging/media/bcm2048/radio-bcm2048.c:2042:63: error: two or more data types in declaration specifiers
vim +2031 drivers/staging/media/bcm2048/radio-bcm2048.c
2025 \
2026 kfree(out); \
2027 \
2028 return count; \
2029 }
2030
> 2031 DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
2032 DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
2033 DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
2034 DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49084 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-21 3:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-20 11:02 [PATCH] staging: radio-bcm2048: Fix checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' unknown
2017-03-20 11:57 ` Dan Carpenter
2017-03-20 12:05 ` Dan Carpenter
2017-03-21 3:54 ` kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).