From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:MEDIA INPUT INFRASTRUCTURE V4L/DVB"
<linux-media@vger.kernel.org>
Subject: Re: [PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err
Date: Fri, 24 Mar 2017 11:28:32 +0300 [thread overview]
Message-ID: <20170324082832.GP32449@mwanda> (raw)
In-Reply-To: <1490334513-7721-1-git-send-email-pushkar.iit@gmail.com>
On Fri, Mar 24, 2017 at 11:18:33AM +0530, Pushkar Jambhlekar wrote:
> Removing hardcoded function name as code is already using __func__
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> index d1a609d2..a51a27b 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> @@ -64,7 +64,7 @@ struct hmm_buffer_object *__bo_alloc(struct kmem_cache *bo_cache)
>
> bo = kmem_cache_alloc(bo_cache, GFP_KERNEL);
> if (!bo)
> - dev_err(atomisp_dev, "%s: __bo_alloc failed!\n", __func__);
> + dev_err(atomisp_dev, "%s: failed!\n", __func__);
The whole printk can be removed. kmem_cache_alloc() has its own better
printks.
regards,
dan carpenter
prev parent reply other threads:[~2017-03-24 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 5:48 [PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err Pushkar Jambhlekar
2017-03-24 8:28 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324082832.GP32449@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pushkar.iit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).