* [PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err
@ 2017-03-24 5:48 Pushkar Jambhlekar
2017-03-24 8:28 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Pushkar Jambhlekar @ 2017-03-24 5:48 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, Alan Cox,
Andrew Morton, Dan Carpenter, Pushkar Jambhlekar
Cc: open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list:STAGING SUBSYSTEM, open list
Removing hardcoded function name as code is already using __func__
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
index d1a609d2..a51a27b 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
@@ -64,7 +64,7 @@ struct hmm_buffer_object *__bo_alloc(struct kmem_cache *bo_cache)
bo = kmem_cache_alloc(bo_cache, GFP_KERNEL);
if (!bo)
- dev_err(atomisp_dev, "%s: __bo_alloc failed!\n", __func__);
+ dev_err(atomisp_dev, "%s: failed!\n", __func__);
return bo;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err
2017-03-24 5:48 [PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err Pushkar Jambhlekar
@ 2017-03-24 8:28 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2017-03-24 8:28 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Alan Cox,
Andrew Morton, open list:STAGING SUBSYSTEM, open list,
open list:MEDIA INPUT INFRASTRUCTURE V4L/DVB
On Fri, Mar 24, 2017 at 11:18:33AM +0530, Pushkar Jambhlekar wrote:
> Removing hardcoded function name as code is already using __func__
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> index d1a609d2..a51a27b 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c
> @@ -64,7 +64,7 @@ struct hmm_buffer_object *__bo_alloc(struct kmem_cache *bo_cache)
>
> bo = kmem_cache_alloc(bo_cache, GFP_KERNEL);
> if (!bo)
> - dev_err(atomisp_dev, "%s: __bo_alloc failed!\n", __func__);
> + dev_err(atomisp_dev, "%s: failed!\n", __func__);
The whole printk can be removed. kmem_cache_alloc() has its own better
printks.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-24 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-24 5:48 [PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err Pushkar Jambhlekar
2017-03-24 8:28 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).