linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Young <sean@mess.org>
To: Chetan Sethi <cpsethi369@gmail.com>
Cc: jarod@wilsonet.com, mchehab@kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: lirc: coding style fix use octal instead of symbolic permission
Date: Fri, 24 Mar 2017 18:06:28 +0000	[thread overview]
Message-ID: <20170324180627.GA14834@gofer.mess.org> (raw)
In-Reply-To: <1486881582-21101-1-git-send-email-cpsethi369@gmail.com>

On Sun, Feb 12, 2017 at 03:39:42PM +0900, Chetan Sethi wrote:
> This is a patch to the lirc_sir.c file that fixes coding style warning
> found by checkpatch.pl
> 
> Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>

Another patch was merged which already fixed this, I'm sorry.

Sean

> ---
>  drivers/staging/media/lirc/lirc_sir.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_sir.c b/drivers/staging/media/lirc/lirc_sir.c
> index c75ae43..426753e 100644
> --- a/drivers/staging/media/lirc/lirc_sir.c
> +++ b/drivers/staging/media/lirc/lirc_sir.c
> @@ -826,14 +826,14 @@ MODULE_AUTHOR("Milan Pikula");
>  #endif
>  MODULE_LICENSE("GPL");
>  
> -module_param(io, int, S_IRUGO);
> +module_param(io, int, 0444);
>  MODULE_PARM_DESC(io, "I/O address base (0x3f8 or 0x2f8)");
>  
> -module_param(irq, int, S_IRUGO);
> +module_param(irq, int, 0444);
>  MODULE_PARM_DESC(irq, "Interrupt (4 or 3)");
>  
> -module_param(threshold, int, S_IRUGO);
> +module_param(threshold, int, 0444);
>  MODULE_PARM_DESC(threshold, "space detection threshold (3)");
>  
> -module_param(debug, bool, S_IRUGO | S_IWUSR);
> +module_param(debug, bool, 0644);
>  MODULE_PARM_DESC(debug, "Enable debugging messages");
> -- 
> 2.7.4

      reply	other threads:[~2017-03-24 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-12  6:39 [PATCH] staging: media: lirc: coding style fix use octal instead of symbolic permission Chetan Sethi
2017-03-24 18:06 ` Sean Young [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170324180627.GA14834@gofer.mess.org \
    --to=sean@mess.org \
    --cc=cpsethi369@gmail.com \
    --cc=jarod@wilsonet.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).