* [PATCH] staging: media: lirc: coding style fix use octal instead of symbolic permission
@ 2017-02-12 6:39 Chetan Sethi
2017-03-24 18:06 ` Sean Young
0 siblings, 1 reply; 2+ messages in thread
From: Chetan Sethi @ 2017-02-12 6:39 UTC (permalink / raw)
To: jarod, mchehab; +Cc: linux-media, Chetan Sethi
This is a patch to the lirc_sir.c file that fixes coding style warning
found by checkpatch.pl
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
drivers/staging/media/lirc/lirc_sir.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_sir.c b/drivers/staging/media/lirc/lirc_sir.c
index c75ae43..426753e 100644
--- a/drivers/staging/media/lirc/lirc_sir.c
+++ b/drivers/staging/media/lirc/lirc_sir.c
@@ -826,14 +826,14 @@ MODULE_AUTHOR("Milan Pikula");
#endif
MODULE_LICENSE("GPL");
-module_param(io, int, S_IRUGO);
+module_param(io, int, 0444);
MODULE_PARM_DESC(io, "I/O address base (0x3f8 or 0x2f8)");
-module_param(irq, int, S_IRUGO);
+module_param(irq, int, 0444);
MODULE_PARM_DESC(irq, "Interrupt (4 or 3)");
-module_param(threshold, int, S_IRUGO);
+module_param(threshold, int, 0444);
MODULE_PARM_DESC(threshold, "space detection threshold (3)");
-module_param(debug, bool, S_IRUGO | S_IWUSR);
+module_param(debug, bool, 0644);
MODULE_PARM_DESC(debug, "Enable debugging messages");
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: lirc: coding style fix use octal instead of symbolic permission
2017-02-12 6:39 [PATCH] staging: media: lirc: coding style fix use octal instead of symbolic permission Chetan Sethi
@ 2017-03-24 18:06 ` Sean Young
0 siblings, 0 replies; 2+ messages in thread
From: Sean Young @ 2017-03-24 18:06 UTC (permalink / raw)
To: Chetan Sethi; +Cc: jarod, mchehab, linux-media
On Sun, Feb 12, 2017 at 03:39:42PM +0900, Chetan Sethi wrote:
> This is a patch to the lirc_sir.c file that fixes coding style warning
> found by checkpatch.pl
>
> Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
Another patch was merged which already fixed this, I'm sorry.
Sean
> ---
> drivers/staging/media/lirc/lirc_sir.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_sir.c b/drivers/staging/media/lirc/lirc_sir.c
> index c75ae43..426753e 100644
> --- a/drivers/staging/media/lirc/lirc_sir.c
> +++ b/drivers/staging/media/lirc/lirc_sir.c
> @@ -826,14 +826,14 @@ MODULE_AUTHOR("Milan Pikula");
> #endif
> MODULE_LICENSE("GPL");
>
> -module_param(io, int, S_IRUGO);
> +module_param(io, int, 0444);
> MODULE_PARM_DESC(io, "I/O address base (0x3f8 or 0x2f8)");
>
> -module_param(irq, int, S_IRUGO);
> +module_param(irq, int, 0444);
> MODULE_PARM_DESC(irq, "Interrupt (4 or 3)");
>
> -module_param(threshold, int, S_IRUGO);
> +module_param(threshold, int, 0444);
> MODULE_PARM_DESC(threshold, "space detection threshold (3)");
>
> -module_param(debug, bool, S_IRUGO | S_IWUSR);
> +module_param(debug, bool, 0644);
> MODULE_PARM_DESC(debug, "Enable debugging messages");
> --
> 2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-24 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-12 6:39 [PATCH] staging: media: lirc: coding style fix use octal instead of symbolic permission Chetan Sethi
2017-03-24 18:06 ` Sean Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).