From: Daniel Scheller <d.scheller.oss@gmail.com>
To: mchehab@kernel.org, linux-media@vger.kernel.org
Subject: [PATCH v2 02/12] [media] dvb-frontends/stv0367: print CPAMP status only if stv_debug is enabled
Date: Fri, 24 Mar 2017 19:23:58 +0100 [thread overview]
Message-ID: <20170324182408.25996-3-d.scheller.oss@gmail.com> (raw)
In-Reply-To: <20170324182408.25996-1-d.scheller.oss@gmail.com>
From: Daniel Scheller <d.scheller@gmx.net>
The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed
everytime tuning succeeds or fails, quite cluttering the normal kernel log.
Use dprintk() instead of printk(KERN_ERR...) so that if the information is
needed, it'll be printed when the stv_debug modparam is enabled.
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
---
drivers/media/dvb-frontends/stv0367.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c
index fc80934..0064d9d 100644
--- a/drivers/media/dvb-frontends/stv0367.c
+++ b/drivers/media/dvb-frontends/stv0367.c
@@ -1262,9 +1262,9 @@ stv0367_ter_signal_type stv0367ter_check_cpamp(struct stv0367_state *state,
dprintk("******last CPAMPvalue= %d at wd=%d\n", CPAMPvalue, wd);
if (CPAMPvalue < CPAMPMin) {
CPAMPStatus = FE_TER_NOCPAMP;
- printk(KERN_ERR "CPAMP failed\n");
+ dprintk("%s: CPAMP failed\n", __func__);
} else {
- printk(KERN_ERR "CPAMP OK !\n");
+ dprintk("%s: CPAMP OK !\n", __func__);
CPAMPStatus = FE_TER_CPAMPOK;
}
--
2.10.2
next prev parent reply other threads:[~2017-03-24 18:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 18:23 [PATCH v2 00/12] stv0367/ddbridge: support CTv6/FlexCT hardware Daniel Scheller
2017-03-24 18:23 ` [PATCH v2 01/12] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional Daniel Scheller
2017-03-26 8:03 ` Matthias Schwarzott
2017-03-26 10:34 ` Daniel Scheller
2017-03-28 5:37 ` Matthias Schwarzott
2017-03-24 18:23 ` Daniel Scheller [this message]
2017-03-24 18:23 ` [PATCH v2 03/12] [media] dvb-frontends/stv0367: refactor defaults table handling Daniel Scheller
2017-03-24 18:24 ` [PATCH v2 04/12] [media] dvb-frontends/stv0367: move out tables, support multiple tab variants Daniel Scheller
2017-03-24 18:24 ` [PATCH v2 05/12] [media] dvb-frontends/stv0367: make PLLSETUP a function, add 58MHz IC speed Daniel Scheller
2017-03-24 18:24 ` [PATCH v2 06/12] [media] dvb-frontends/stv0367: make full reinit on set_frontend() optional Daniel Scheller
2017-03-24 18:24 ` [PATCH v2 07/12] [media] dvb-frontends/stv0367: support reading if_khz from tuner config Daniel Scheller
2017-03-24 18:24 ` [PATCH v2 08/12] [media] dvb-frontends/stv0367: selectable QAM FEC Lock status register Daniel Scheller
2017-03-24 18:24 ` [PATCH v2 09/12] [media] dvb-frontends/stv0367: fix symbol rate conditions in cab_SetQamSize() Daniel Scheller
2017-03-24 18:24 ` [PATCH v2 10/12] [media] dvb-frontends/stv0367: add defaults for use w/DD-branded devices Daniel Scheller
2017-03-24 18:24 ` [PATCH v2 11/12] [media] dvb-frontends/stv0367: add Digital Devices compatibility Daniel Scheller
2017-03-24 18:24 ` [PATCH v2 12/12] [media] ddbridge: support STV0367-based cards and modules Daniel Scheller
2017-03-25 18:13 ` Daniel Scheller
2017-03-26 16:46 ` kbuild test robot
2017-03-26 22:20 ` Daniel Scheller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324182408.25996-3-d.scheller.oss@gmail.com \
--to=d.scheller.oss@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).