From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Daniel Vetter <daniel.vetter@intel.com>,
dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Inki Dae <inki.dae@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCHv5 04/11] exynos_hdmi: add CEC notifier support
Date: Thu, 30 Mar 2017 23:35:27 +0100 [thread overview]
Message-ID: <20170330223527.GK7909@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170329141543.32935-5-hverkuil@xs4all.nl>
On Wed, Mar 29, 2017 at 04:15:36PM +0200, Hans Verkuil wrote:
> + cec_notifier_set_phys_addr(hdata->notifier,
> + cec_get_edid_phys_addr(edid));
This pattern causes problems - can we have the notifier taking the EDID
please, and stubs in cec-notifier.h to stub that out?
Maybe something like cec_notifier_set_phys_addr_from_edid(edid) ?
Having converted the tda998x code over to your new notifier, the 0-day
builder reported this tonight:
>> ERROR: "cec_get_edid_phys_addr" [drivers/gpu/drm/i2c/tda998x.ko] undefined!
which is caused exactly by this problem. I can add #ifdefs into the
tda998x driver, but as you're already stubbing out
cec_notifier_set_phys_addr() in cec-notifier.h, it would be stupid to
have to resort to #ifdefs in driver code to solve this issue.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-03-30 22:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 14:15 [PATCHv5 00/11] video/exynos/sti/cec: add CEC notifier & use in drivers Hans Verkuil
2017-03-29 14:15 ` [PATCHv5 01/11] cec-edid: rename cec_get_edid_phys_addr Hans Verkuil
2017-03-29 14:15 ` [PATCHv5 02/11] media: add CEC notifier support Hans Verkuil
2017-03-29 14:15 ` [PATCHv5 03/11] cec: integrate " Hans Verkuil
2017-03-29 15:44 ` [PATCHv5.1 " Hans Verkuil
2017-03-29 14:15 ` [PATCHv5 04/11] exynos_hdmi: add " Hans Verkuil
2017-03-30 21:37 ` Krzysztof Kozlowski
2017-03-30 22:35 ` Russell King - ARM Linux [this message]
2017-03-31 8:05 ` Hans Verkuil
2017-03-29 14:15 ` [PATCHv5 05/11] ARM: dts: exynos: add HDMI controller phandle to exynos4.dtsi Hans Verkuil
2017-03-30 21:34 ` Krzysztof Kozlowski
2017-03-29 14:15 ` [PATCHv5 06/11] s5p-cec.txt: document the HDMI controller phandle Hans Verkuil
2017-03-30 21:37 ` Krzysztof Kozlowski
2017-03-29 14:15 ` [PATCHv5 07/11] s5p-cec: add cec-notifier support, move out of staging Hans Verkuil
2017-03-30 21:38 ` Krzysztof Kozlowski
2017-03-29 14:15 ` [PATCHv5 08/11] sti: hdmi: add CEC notifier support Hans Verkuil
2017-03-29 14:15 ` [PATCHv5 09/11] stih-cec.txt: document new hdmi phandle Hans Verkuil
2017-03-29 14:15 ` [PATCHv5 10/11] stih-cec: add CEC notifier support Hans Verkuil
2017-03-29 14:15 ` [PATCHv5 11/11] arm: sti: update sti-cec for " Hans Verkuil
2017-03-30 7:41 ` Benjamin Gaignard
2017-03-30 9:30 ` Patrice CHOTARD
2017-03-30 9:32 ` Hans Verkuil
2017-03-29 15:55 ` [PATCHv5 00/11] video/exynos/sti/cec: add CEC notifier & use in drivers Benjamin Gaignard
2017-03-29 17:47 ` Daniel Vetter
2017-03-29 19:59 ` Hans Verkuil
2017-03-30 7:47 ` Daniel Vetter
2017-03-30 20:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170330223527.GK7909@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=krzk@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox