From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Helen Koike <helen.koike@collabora.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] vidioc-enumin/output.rst: improve documentation
Date: Fri, 31 Mar 2017 07:05:08 -0300 [thread overview]
Message-ID: <20170331070508.7a8eae16@vento.lan> (raw)
In-Reply-To: <dfd64830-b66d-044d-2a40-82210a32c18a@xs4all.nl>
Em Fri, 31 Mar 2017 10:58:39 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> The V4L2_INPUT_TYPE_CAMERA and V4L2_OUTPUT_TYPE_ANALOG descriptions were
> hopelessly out of date. Fix this, and also fix a few style issues in these
> documents. Finally add the missing documentation for V4L2_OUTPUT_TYPE_ANALOGVGAOVERLAY
> (only used by the zoran driver).
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
Patch looks OK to me, but see below.
> Question: should we perhaps add _TYPE_VIDEO aliases?
IMHO, let's rename it to _TYPE_VIDEO (or STREAM, or V_STREAM), and make
_TYPE_CAMERA an alias, e. g.:
#define V4L2_INPUT_TYPE_VIDEO 2
#define V4L2_INPUT_TYPE_CAMERA V4L2_INPUT_TYPE_VIDEO
This way, we'll let clearer what's currently preferred. We should also
change it at the documentation, mentioning that V4L2_INPUT_TYPE_CAMERA
is an alias, due to historical reasons.
Thanks,
Mauro
next prev parent reply other threads:[~2017-03-31 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 8:58 [PATCH] vidioc-enumin/output.rst: improve documentation Hans Verkuil
2017-03-31 10:05 ` Mauro Carvalho Chehab [this message]
2017-03-31 12:12 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331070508.7a8eae16@vento.lan \
--to=mchehab@s-opensource.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox