From: Greg KH <gregkh@linuxfoundation.org>
To: Haim Daniel <haimdaniel@gmail.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH v3] [media] staging: css2400: fix checkpatch error
Date: Tue, 18 Apr 2017 13:31:26 +0200 [thread overview]
Message-ID: <20170418113126.GA15397@kroah.com> (raw)
In-Reply-To: <1490773808-7242-1-git-send-email-haimdaniel@gmail.com>
On Wed, Mar 29, 2017 at 10:50:08AM +0300, Haim Daniel wrote:
> isp_capture_defs.h: clean up ERROR: Macros with complex values should be enclosed in parentheses
>
> Signed-off-by: Haim Daniel <haimdaniel@gmail.com>
> ---
> .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
> index aa413df..117c7a2 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h
> @@ -19,7 +19,7 @@
> #define _ISP_CAPTURE_BITS_PER_ELEM 32 /* only for data, not SOP */
> #define _ISP_CAPTURE_BYTES_PER_ELEM (_ISP_CAPTURE_BITS_PER_ELEM/8 )
> #define _ISP_CAPTURE_BYTES_PER_WORD 32 /* 256/8 */
> -#define _ISP_CAPTURE_ELEM_PER_WORD _ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM
> +#define _ISP_CAPTURE_ELEM_PER_WORD (_ISP_CAPTURE_BYTES_PER_WORD / _ISP_CAPTURE_BYTES_PER_ELEM)
Why only fix one of these instances?
And why is this define even needed? No one touches it, right?
Also, please cc: Alan on patches to this driver when you resend. You
are using scripts/get_maintainer.pl, right?
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-18 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 5:36 [PATCH]: staging: media: css2400: fix checkpatch error Haim Daniel
2017-03-29 7:12 ` [PATCH v2] [media] staging: " Haim Daniel
2017-03-29 7:28 ` Greg KH
2017-03-29 7:50 ` [PATCH v3] " Haim Daniel
2017-04-18 11:31 ` Greg KH [this message]
2017-03-29 7:38 ` [PATCH]: staging: media: " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418113126.GA15397@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=haimdaniel@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).