Re: [PATCH v8 00/10] Qualcomm video decoder/encoder driver

Stanimir Varbanov
2017-05-05T13:43:05Z

Hi Hans,

On 05/05/2017 03:44 PM, Hans Verkuil wrote:
> Hi Stanimir,
>
> It looks good to me. I do think that patch 01/10 shouldn't go through
> media. This might mean that we have to drop the COMPILE_TEST dependency
> on the media driver until this firmware driver patch gets merged, which
> is fine with me as long as this is clearly stated in the commit log for
> the media Kconfig. Let me know what you want to do with this.

OK, the best I can do is to drop COMPILE_TEST for Venus driver in this
patch set and work separately on qcom_scm firmware driver patching. Thus
I will repost v9 version next week.

>
> I also saw some comments for patch 05/10, but I'm not sure if that would
> block merging this driver or can be fixed afterwards.

I will prefix the exported symbols from venus-core driver as pointed by
Sakari in next v9 version plus fixes for few signed-unsigned compare
warnings.

--
regards,
Stan