linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, pavel@ucw.cz
Subject: Re: [RFC 2/3] dt: bindings: Add lens-focus binding for image sensors
Date: Thu, 4 May 2017 16:33:17 +0200	[thread overview]
Message-ID: <20170504143317.obpt2nmsjiypn4d2@earth> (raw)
In-Reply-To: <1493720749-31509-3-git-send-email-sakari.ailus@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

Hi,

On Tue, May 02, 2017 at 01:25:48PM +0300, Sakari Ailus wrote:
> The lens-focus property contains a phandle to the lens voice coil driver
> that is associated to the sensor; typically both are contained in the same
> camera module.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  Documentation/devicetree/bindings/media/video-interfaces.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt
> index d6c62bc..e52aefc 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
> @@ -77,6 +77,9 @@ Optional properties
>    the child nodes of the LED driver describing individual LEDs. Only
>    valid for device nodes that are related to an image sensor.
>  
> +- lens-focus: A phandle to the node of the lens. Only valid for device
> +  nodes that are related to an image sensor.

s/of the lens/of the focus lens controller/

Also I wonder about the second sentence. That sentence could
basically be added to every property, so can't we just drop it?

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-05-04 14:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02 10:25 [RFC 0/3] Document bindings for camera modules and associated flash devices Sakari Ailus
2017-05-02 10:25 ` [RFC 1/3] dt: bindings: Add a binding for flash devices associated to a sensor Sakari Ailus
2017-05-04 14:27   ` Sebastian Reichel
2017-05-05  8:28     ` Sakari Ailus
2017-05-05  8:38       ` Sebastian Reichel
2017-05-02 10:25 ` [RFC 2/3] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
2017-05-04 14:33   ` Sebastian Reichel [this message]
2017-05-02 10:25 ` [RFC 3/3] dt: bindings: Add a binding for referencing EEPROM from camera sensors Sakari Ailus
2017-05-04 14:38   ` Sebastian Reichel
2017-05-05  8:49     ` Sakari Ailus
2017-05-04 22:01 ` [RFC 0/3] Document bindings for camera modules and associated flash devices Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504143317.obpt2nmsjiypn4d2@earth \
    --to=sebastian.reichel@collabora.co.uk \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).