From: Sakari Ailus <sakari.ailus@iki.fi>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Steve Longerbeam <slongerbeam@gmail.com>,
Peter Rosin <peda@axentia.se>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
kernel@pengutronix.de, Sascha Hauer <s.hauer@pengutronix.de>,
Steve Longerbeam <steve_longerbeam@mentor.com>
Subject: Re: [PATCH v3 2/2] [media] platform: add video-multiplexer subdevice driver
Date: Fri, 5 May 2017 01:47:14 +0300 [thread overview]
Message-ID: <20170504224714.GF7456@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20170504203208.GC7456@valkosipuli.retiisi.org.uk>
On Thu, May 04, 2017 at 11:32:08PM +0300, Sakari Ailus wrote:
> Hi Philipp,
>
> On Thu, May 04, 2017 at 03:38:57PM +0200, Philipp Zabel wrote:
> ...
> > +static const struct of_device_id video_mux_dt_ids[] = {
> > + { .compatible = "video-mux", },
> > + { /* sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(of, video_mux_dt_ids);
> > +
> > +static struct platform_driver video_mux_driver = {
>
> Shouldn't this be const?
To reply myself --- no. Driver registration requires that, which makes
perfect sense. Please ignore the comment.
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2017-05-04 22:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 13:38 [PATCH v3 1/2] [media] dt-bindings: Add bindings for video-multiplexer device Philipp Zabel
2017-05-04 13:38 ` [PATCH v3 2/2] [media] platform: add video-multiplexer subdevice driver Philipp Zabel
2017-05-04 14:21 ` Sebastian Reichel
2017-05-04 15:14 ` Philipp Zabel
2017-05-04 14:59 ` Kieran Bingham
2017-05-04 15:13 ` Philipp Zabel
2017-05-04 20:32 ` Sakari Ailus
2017-05-04 22:47 ` Sakari Ailus [this message]
2017-05-04 14:13 ` [PATCH v3 1/2] [media] dt-bindings: Add bindings for video-multiplexer device Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504224714.GF7456@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=pavel@ucw.cz \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=slongerbeam@gmail.com \
--cc=steve_longerbeam@mentor.com \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox