From: Sean Young <sean@mess.org>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Wolfram Sang <wsa-dev@sang-engineering.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andi Shyti <andi.shyti@samsung.com>,
Geliang Tang <geliangtang@gmail.com>,
Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: Re: [PATCH 2/4] [media] imon: better code the pad_mouse toggling
Date: Thu, 18 May 2017 15:23:19 +0100 [thread overview]
Message-ID: <20170518142319.GA14397@gofer.mess.org> (raw)
In-Reply-To: <cdce7df07641f6f364a241bfa77ba76ade9cae68.1495116400.git.mchehab@s-opensource.com>
On Thu, May 18, 2017 at 11:06:44AM -0300, Mauro Carvalho Chehab wrote:
> The logic with toggles the pad_mouse is confusing. Now, gcc 7.1
> complains about it:
>
> drivers/media/rc/imon.c: In function 'imon_incoming_scancode':
> drivers/media/rc/imon.c:1725:23: warning: '~' on a boolean expression [-Wbool-operation]
> ictx->pad_mouse = (~ictx->pad_mouse) & 0x1;
> ^
> drivers/media/rc/imon.c:1725:23: note: did you mean to use logical not?
> ictx->pad_mouse = (~ictx->pad_mouse) & 0x1;
> ^
> !
>
> Rewrite it to be clearer for both code reviewers and gcc.
This was already spotted by Arnd.
https://patchwork.linuxtv.org/patch/41270/
Thanks
Sean
next prev parent reply other threads:[~2017-05-18 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 14:06 [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON() Mauro Carvalho Chehab
2017-05-18 14:06 ` [PATCH 2/4] [media] imon: better code the pad_mouse toggling Mauro Carvalho Chehab
2017-05-18 14:23 ` Sean Young [this message]
2017-05-18 14:06 ` [PATCH 3/4] [media] s5p-jpeg: don't return a random width/height Mauro Carvalho Chehab
2017-05-19 7:22 ` Andrzej Pietrasiewicz
2017-05-18 14:06 ` [PATCH 4/4] [media] mtk_vcodec_dec: return error at mtk_vdec_pic_info_update() Mauro Carvalho Chehab
2017-05-18 18:48 ` [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON() Andrey Utkin
2017-05-19 16:55 ` Anton Sviridenko
2017-05-18 20:55 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518142319.GA14397@gofer.mess.org \
--to=sean@mess.org \
--cc=andi.shyti@samsung.com \
--cc=daniel.wagner@bmw-carit.de \
--cc=geliangtang@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@s-opensource.com \
--cc=sakari.ailus@linux.intel.com \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).