From: "Michael Büsch" <m@bues.ch>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Bluecherry Maintainers <maintainers@bluecherrydvr.com>,
Andrey Utkin <andrey.utkin@corp.bluecherry.net>
Subject: Re: [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON()
Date: Thu, 18 May 2017 22:55:09 +0200 [thread overview]
Message-ID: <20170518225509.29d05893@wiggum> (raw)
In-Reply-To: <754069659fbb44b458d8a8bef67d8f3f235d0c87.1495116400.git.mchehab@s-opensource.com>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On Thu, 18 May 2017 11:06:43 -0300
Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
> diff --git a/drivers/media/tuners/fc0011.c b/drivers/media/tuners/fc0011.c
> index 192b1c7740df..145407dee3db 100644
> --- a/drivers/media/tuners/fc0011.c
> +++ b/drivers/media/tuners/fc0011.c
> @@ -342,6 +342,7 @@ static int fc0011_set_params(struct dvb_frontend *fe)
> switch (vco_sel) {
> default:
> WARN_ON(1);
> + return -EINVAL;
> case 0:
> if (vco_cal < 8) {
> regs[FC11_REG_VCOSEL] &= ~(FC11_VCOSEL_1 | FC11_VCOSEL_2);
This fall through is intentional, but I guess returning an error is OK,
too. This should not happen anyway.
I cannot test this, though.
Acked-by: Michael Büsch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-05-18 21:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 14:06 [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON() Mauro Carvalho Chehab
2017-05-18 14:06 ` [PATCH 2/4] [media] imon: better code the pad_mouse toggling Mauro Carvalho Chehab
2017-05-18 14:23 ` Sean Young
2017-05-18 14:06 ` [PATCH 3/4] [media] s5p-jpeg: don't return a random width/height Mauro Carvalho Chehab
2017-05-19 7:22 ` Andrzej Pietrasiewicz
2017-05-18 14:06 ` [PATCH 4/4] [media] mtk_vcodec_dec: return error at mtk_vdec_pic_info_update() Mauro Carvalho Chehab
2017-05-18 18:48 ` [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON() Andrey Utkin
2017-05-19 16:55 ` Anton Sviridenko
2017-05-18 20:55 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518225509.29d05893@wiggum \
--to=m@bues.ch \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@infradead.org \
--cc=mchehab@s-opensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox