From: Hans de Goede <hdegoede@redhat.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Subject: [PATCH 7/7] staging: atomisp: Make ov2680 driver less chatty
Date: Sun, 28 May 2017 14:31:53 +0200 [thread overview]
Message-ID: <20170528123153.18613-7-hdegoede@redhat.com> (raw)
In-Reply-To: <20170528123153.18613-1-hdegoede@redhat.com>
There is no reason for all this printk spamming and certainly
not at an error log level.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/staging/media/atomisp/i2c/ov2680.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ov2680.c b/drivers/staging/media/atomisp/i2c/ov2680.c
index 6dd466558701..3cabfe54c669 100644
--- a/drivers/staging/media/atomisp/i2c/ov2680.c
+++ b/drivers/staging/media/atomisp/i2c/ov2680.c
@@ -1191,9 +1191,8 @@ static int ov2680_detect(struct i2c_client *client)
OV2680_SC_CMMN_SUB_ID, &high);
revision = (u8) high & 0x0f;
- dev_err(&client->dev, "sensor_revision id = 0x%x\n", id);
- dev_err(&client->dev, "detect ov2680 success\n");
- dev_err(&client->dev, "################5##########\n");
+ dev_info(&client->dev, "sensor_revision id = 0x%x\n", id);
+
return 0;
}
@@ -1448,8 +1447,6 @@ static int ov2680_probe(struct i2c_client *client,
void *pdata;
unsigned int i;
- printk("++++ov2680_probe++++\n");
- dev_info(&client->dev, "++++ov2680_probe++++\n");
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (!dev) {
dev_err(&client->dev, "out of memory\n");
--
2.13.0
prev parent reply other threads:[~2017-05-28 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 12:31 [PATCH 1/7] staging: atomisp: Fix calling efivar_entry_get() with unaligned arguments Hans de Goede
2017-05-28 12:31 ` [PATCH 2/7] staging: atomisp: Do not call dev_warn with a NULL device Hans de Goede
2017-05-28 13:06 ` Andy Shevchenko
2017-05-28 12:31 ` [PATCH 3/7] staging: atomisp: Set step to 0 for mt9m114 menu control Hans de Goede
2017-05-28 12:31 ` [PATCH 4/7] staging: atomisp: Add INT0310 ACPI id to gc0310 driver Hans de Goede
2017-05-28 12:31 ` [PATCH 5/7] staging: atomisp: Add OVTI2680 ACPI id to ov2680 driver Hans de Goede
2017-05-28 12:31 ` [PATCH 6/7] staging: atomisp: Ignore errors from second gpio in " Hans de Goede
2017-05-28 12:31 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170528123153.18613-7-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox