From: Vincent McIntyre <vincent.mcintyre@gmail.com>
To: Olli Salonen <olli.salonen@iki.fi>
Cc: linux-media <linux-media@vger.kernel.org>, hans.verkuil@cisco.com
Subject: Re: media_build: fails to install
Date: Sat, 3 Jun 2017 15:26:51 +1000 [thread overview]
Message-ID: <20170603052648.GA15483@ubuntu.windy> (raw)
In-Reply-To: <CAAZRmGw=S+SGAHUOOL7wYNj040n9h6B9qNtSakHqzLpJMCGx1A@mail.gmail.com>
On Wed, May 31, 2017 at 03:57:04AM +0300, Olli Salonen wrote:
> It seems that I'm able to build the media_build correctly on Ubuntu
> 16.04.2 with kernel 4.8, but make install fails:
>
> ~/src/media_build$ sudo make install
> make -C /home/olli/src/media_build/v4l install
> make[1]: Entering directory '/home/olli/src/media_build/v4l'
> make[1]: *** No rule to make target 'media-install', needed by 'install'. Stop.
> make[1]: Leaving directory '/home/olli/src/media_build/v4l'
> Makefile:15: recipe for target 'install' failed
> make: *** [install] Error 2
>
I can confirm this issue.
The reason is that scripts/make_makefile.pl aborts
make[1]: Entering directory '/home/me/git/clones/media_build/v4l'^M
scripts/make_makefile.pl^M
Can't handle includes! In ../linux/drivers/staging/media/atomisp/pci/atomisp2/css2400/Makefile at scripts/ make_makefile.pl line 109, <GEN152> line 4.^M
because that css2400/Makefile includes another:
$ cat ../linux/drivers/staging/media/atomisp/pci/atomisp2/css2400/Makefile
ccflags-y += -DISP2400B0
ISP2400B0 := y
include $(srctree)/$(src)/../Makefile.common
The abort of scripts/make_makefile.pl means that the v4l/Makefile
does not get completely written out, in particular the rules for
making the 'media-install' target.
I am not sure how to fix this. The make_makefile.pl deliberately
falls over when given an include to deal with, so there must be
some other mechanism in the media_build framework that handles
this kind of thing. But I am not aware of it. Hans, help pretty please?
Vince
prev parent reply other threads:[~2017-06-03 5:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 0:57 media_build: fails to install Olli Salonen
2017-06-03 5:26 ` Vincent McIntyre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603052648.GA15483@ubuntu.windy \
--to=vincent.mcintyre@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=olli.salonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox