From: Vincent McIntyre <vincent.mcintyre@gmail.com>
To: linux-media@vger.kernel.org
Subject: Re: [media_build] regression at 3a17e11 "update v4.10_sched_signal.patch"
Date: Fri, 9 Jun 2017 00:19:28 +1000 [thread overview]
Message-ID: <20170608141926.GA16444@ubuntu.windy> (raw)
In-Reply-To: <20170608132826.GB11167@ubuntu.windy>
>
> $ cat drivers/media/rc/lirc_dev.c.rej
> --- drivers/media/rc/lirc_dev.c
> +++ drivers/media/rc/lirc_dev.c
> @@ -18,7 +18,7 @@
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> #include <linux/module.h>
> -#include <linux/sched/signal.h>
> +#include <linux/sched.h>
> #include <linux/ioctl.h>
> #include <linux/poll.h>
> #include <linux/mutex.h>
>
A bit of staring brings this to light:
The file that is being patched has extra lines relative to the patch
18 #undef pr_fmt
19 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
20
21 #include <linux/module.h>
** 22 #include <linux/kernel.h>
23 #include <linux/sched/signal.h>
** 24 #include <linux/errno.h>
25 #include <linux/ioctl.h>
26 #include <linux/fs.h>
27 #include <linux/poll.h>
28 #include <linux/completion.h>
29 #include <linux/mutex.h>
30 #include <linux/wait.h>
This hunk applies cleanly, and seems to match up with recent kernel
code (eg
174cd4b1e5fbd0d74c68cf3a74f5bd4923485512
sched/headers: Prepare to move signal wakeup & sigpending methods
from <linux/sched.h> into <linux/sched/signal.h>)
@@ -20,7 +20,7 @@
#include <linux/module.h>
#include <linux/kernel.h>
-#include <linux/sched/signal.h>
+#include <linux/sched.h>
#include <linux/errno.h>
#include <linux/ioctl.h>
#include <linux/fs.h>
HTH
Vince
next prev parent reply other threads:[~2017-06-08 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 13:13 [media_build] regression at 3a17e11 "update v4.10_sched_signal.patch" Vincent McIntyre
2017-06-08 13:28 ` Vincent McIntyre
2017-06-08 14:19 ` Vincent McIntyre [this message]
2017-06-08 14:42 ` Hans Verkuil
2017-06-25 6:45 ` Vincent McIntyre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608141926.GA16444@ubuntu.windy \
--to=vincent.mcintyre@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox