Linux Media Controller development
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: Yong Zhi <yong.zhi@intel.com>,
	linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
	jian.xu.zheng@intel.com, tfiga@chromium.org,
	rajmohan.mani@intel.com, tuukka.toivonen@intel.com,
	hyungwoo.yang@intel.com, divagar.mohandass@intel.com,
	hverkuil@xs4all.nl
Subject: Re: [PATCH v3 1/3] videodev2.h, v4l2-ioctl: add IPU3 raw10 color format
Date: Thu, 15 Jun 2017 01:38:46 +0300	[thread overview]
Message-ID: <20170614223846.GV12407@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20170614144840.4260501d@alans-desktop>

On Wed, Jun 14, 2017 at 02:48:40PM +0100, Alan Cox wrote:
> On Tue, 13 Jun 2017 15:17:14 -0500
> Yong Zhi <yong.zhi@intel.com> wrote:
> 
> > Add IPU3 specific formats:
> > 
> > 	V4L2_PIX_FMT_IPU3_SBGGR10
> > 	V4L2_PIX_FMT_IPU3_SGBRG10
> > 	V4L2_PIX_FMT_IPU3_SGRBG10
> > 	V4L2_PIX_FMT_IPU3_SRGGB10
> 
> As I said before these are just more bitpacked bayer formats with no
> reason to encode them as IPUv3 specific names.

I must have missed that comment --- the format is pretty unusual still.
Basically it rams as much pixels into a 256-bit DMA word as there's room and
then leaves the rest of the DMA word empty (6 bits in this case).

The newer IPUs do not use this format AFAIK (they do use other unusual
formats though). I haven't seen such formats being used by other non-IPU
hardware either.

I think I'd keep this IPU specific unless there's an indication the same
formats might be used elsewhere. The other packed formats that have been
defined in V4L2 are hardware independent.

Cc Hans, too.

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

  parent reply	other threads:[~2017-06-14 22:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 20:17 [PATCH v3 0/3] [PATCH v3 0/3] [media] add IPU3 CIO2 CSI2 driver Yong Zhi
2017-06-13 20:17 ` [PATCH v3 1/3] videodev2.h, v4l2-ioctl: add IPU3 raw10 color format Yong Zhi
2017-06-14 13:48   ` Alan Cox
2017-06-14 15:21     ` Zhi, Yong
2017-06-14 22:38     ` Sakari Ailus [this message]
2017-06-13 20:17 ` [PATCH v3 2/3] doc-rst: add IPU3 raw10 bayer pixel format definitions Yong Zhi
2017-06-13 20:17 ` [PATCH 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver Yong Zhi
2017-06-14  0:01   ` Tomasz Figa
2017-06-14  2:32     ` Zhi, Yong
2017-06-14  2:58       ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170614223846.GV12407@valkosipuli.retiisi.org.uk \
    --to=sakari.ailus@iki.fi \
    --cc=divagar.mohandass@intel.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=hverkuil@xs4all.nl \
    --cc=hyungwoo.yang@intel.com \
    --cc=jian.xu.zheng@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=rajmohan.mani@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tfiga@chromium.org \
    --cc=tuukka.toivonen@intel.com \
    --cc=yong.zhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox