From: Sakari Ailus <sakari.ailus@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: Re: [RFC PATCH 2/2] media/uapi/v4l: clarify cropcap/crop/selection behavior
Date: Fri, 16 Jun 2017 16:08:55 +0300 [thread overview]
Message-ID: <20170616130855.GR12407@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20170508143506.16448-2-hverkuil@xs4all.nl>
Hi Hans,
On Mon, May 08, 2017 at 04:35:06PM +0200, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Unfortunately the use of 'type' was inconsistent for multiplanar
> buffer types. Starting with 4.12 both the normal and _MPLANE variants
> are allowed, thus making it possible to write sensible code.
>
> Yes, we messed up :-(
Things worse than this have happened. :-)
I don't think in general I would write about driver bugs that have already
been fixed in developer documentation. That said, I'm not sure how otherwise
developers would learn about this, but OTOH has it been reported to us as a
bug?
Marek, Sylwester: any idea how widely the drivers in question are in use? If
there's a real chance of hitting this, then it does make sense to mention it
in the documentation.
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2017-06-16 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 14:35 [RFC PATCH 1/2] v4l2-ioctl/exynos: fix G/S_SELECTION's type handling Hans Verkuil
2017-05-08 14:35 ` [RFC PATCH 2/2] media/uapi/v4l: clarify cropcap/crop/selection behavior Hans Verkuil
2017-06-16 13:08 ` Sakari Ailus [this message]
2017-06-18 21:25 ` Sylwester Nawrocki
2017-06-19 7:35 ` Hans Verkuil
2017-06-19 9:17 ` Sylwester Nawrocki
2017-06-16 12:58 ` [RFC PATCH 1/2] v4l2-ioctl/exynos: fix G/S_SELECTION's type handling Sakari Ailus
2017-06-18 20:53 ` Sylwester Nawrocki
2017-06-18 21:18 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616130855.GR12407@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox