Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]

Hi!

> > > These types devices aren't directly related to the sensor, but are
> > > nevertheless handled by the smiapp driver due to the relationship of these
> > > component to the main part of the camera module --- the sensor.
> > > 
> > > Additionally, for the async sub-device registration to work, the notifier
> > > containing matching fwnodes will need to be registered. This is natural to
> > > perform in a sensor driver as well.
> > > 
> > > This does not yet address providing the user space with information on how
> > > to associate the sensor, lens or EEPROM devices but the kernel now has the
> > > necessary information to do that.
> > 
> > Do I understand it correctly that basically every sensor driver (in my
> > case et8ek8) needs to get this kind of support? I2c leds are cheap,
> > and may be asociated with pretty much any sensor, AFAICT.
> 
> That's right.
> 
> > 
> > This is quite a lot of boilerplate for that. Would it make sense to
> > provide helper function at least for this?
> 
> Yes. I've been thinking of having helper functions for notifiers and
> sub-notifiers. Most of the receiver drivers are implementing exactly the
> same thing but with different twists (read: bugs).

Agreed, helpers would be nice. Ping me if you have them, I'll happily
test it with et8ek8. (Or I can try to create them, but...)

If we move lens/flash to the sensor, this one can probably be dropped:

https://git.linuxtv.org/sailus/media_tree.git/commit/?h=ccp2&id=1796bbce05964f86cf546557a96626b2bdebe65b



									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]