From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:49078 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751124AbdFTMgy (ORCPT ); Tue, 20 Jun 2017 08:36:54 -0400 Date: Tue, 20 Jun 2017 09:36:45 -0300 From: Mauro Carvalho Chehab To: Daniel Scheller Cc: linux-media@vger.kernel.org, mchehab@kernel.org, Hans Verkuil , liplianin@netup.ru, rjkm@metzlerbros.de, crope@iki.fi, "Jasmin J." Subject: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware Message-ID: <20170620093645.6f72fd1a@vento.lan> In-Reply-To: <20170619221821.022fc473@macbox> References: <20170329164313.14636-1-d.scheller.oss@gmail.com> <20170412212327.5b75be19@macbox> <20170507174212.2e45ab71@audiostation.wuest.de> <20170528234537.3bed2dde@macbox> <20170619221821.022fc473@macbox> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 19 Jun 2017 22:18:21 +0200 Daniel Scheller escreveu: > Am Sun, 28 May 2017 23:45:37 +0200 > schrieb Daniel Scheller : > > > Am Sun, 7 May 2017 17:42:12 +0200 > > schrieb Daniel Scheller : > > > > > Am Wed, 12 Apr 2017 21:23:27 +0200 > > > schrieb Daniel Scheller : > > > > > > > Am Wed, 29 Mar 2017 18:43:00 +0200 > > > > schrieb Daniel Scheller : > > > > > > > > > From: Daniel Scheller > > > > > > > > > > Third iteration of the DD CineCTv6/FlexCT support patches with > > > > > mostly all things cleaned up that popped up so far. Obsoletes V1 > > > > > and V2 series. > > > > > > > > > > These patches enhance the functionality of dvb-frontends/stv0367 > > > > > to work with Digital Devices hardware driven by the ST STV0367 > > > > > demodulator chip and adds probe & attach bits to ddbridge to > > > > > make use of them, effectively enabling full support for > > > > > CineCTv6 PCIe bridges and (older) DuoFlex CT addon > > > > > modules. > > > > > > > > Since V1 was sent over five weeks ago: Ping? Anyone? I'd really > > > > like to get this upstreamed. > > > > > > Don't want to sound impatient, but V1 nears nine weeks, so: Second > > > Ping. > > > > Friendly third time Ping on this - Really, I'd like to have this > > merged so those quite aging (but still fine) DD CineCTv6 boards > > finally are supported without having to install out-of-tree drivers > > which even break the V4L-DVB subsystem... > > Well. From how things look, these and the cxd2841er+C2T2 ddbridge > support patches won't make it in time for the 4.13 merge window. There is time. I just merged this series today. The thing is that we currently have few developers working on DVB, and no sub-maintainers. Due to that, I need to review them myself, with I usually do after reviewing/applying patches from sub-maintainers. > Also, unfortunately, the original owners and/or maintainers of the > affected drivers (besides cxd2841er), namely stv0367 and ddbridge, > either are MIA or not interested in reviewing or acking this. Yeah, it would be great if Ralph would have some time to review them, or to submit a new series adding all pending features from DD drivers upstream. > I have plenty of more work (patches) done, all building upon this CT > and C2T2 hardware support, which - together with the work Jasmin has > done regarding the en50221 and cxd2099 support - would finally bring > the in-tree ddbridge driver on par with the package Digital Devices' > provides, having addressed most of the critics the previous attempts to > bump the driver received (incremental changes which are more or less > easy to review, from what can be done by tearing tarballs without > proper changelogs apart). Both Jasmin and Thomas could have reviewed it, and replied if they tested it, and on what conditions. I tend to give people some time to review/test patches, before doing my review, as I don't usually have time for testing everything myself. > > The original series of this will be four(!) months old soon :/ > > Is there anything wrong with this? How to proceed with this? > > (Cc Hans since you also seem to be reviewing patches) Hans is focused at V4L2 side. > > That said, fourth ping. Btw, while you're here, it would be great if you could take a look on those warnings (that comes via smatch): drivers/media/pci/ddbridge/ddbridge-core.c:1009 input_tasklet() warn: this loop depends on readl() succeeding drivers/media/pci/ddbridge/ddbridge-core.c:1353 flashio() warn: this loop depends on readl() succeeding drivers/media/pci/ddbridge/ddbridge-core.c:1373 flashio() warn: this loop depends on readl() succeeding Regards, Mauro