public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-media@vger.kernel.org,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Gustavo Padovan <gustavo.padovan@collabora.com>
Subject: Re: [PATCH 01/12] [media] vb2: add explicit fence user API
Date: Mon, 26 Jun 2017 12:39:36 -0300	[thread overview]
Message-ID: <20170626153936.GB3090@jade> (raw)
In-Reply-To: <201706182254.xqhcA9D6%fengguang.wu@intel.com>

2017-06-18 kbuild test robot <lkp@intel.com>:

> Hi Gustavo,
> 
> [auto build test ERROR on linuxtv-media/master]
> [also build test ERROR on v4.12-rc5 next-20170616]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Gustavo-Padovan/vb2-add-explicit-fence-user-API/20170618-210740
> base:   git://linuxtv.org/media_tree.git master
> config: x86_64-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All error/warnings (new ones prefixed by >>):
> 
>    drivers/staging/media//atomisp/pci/atomisp2/atomisp_ioctl.c: In function 'atomisp_qbuf':
> >> drivers/staging/media//atomisp/pci/atomisp2/atomisp_ioctl.c:1297:10: error: 'struct v4l2_buffer' has no member named 'reserved2'; did you mean 'reserved'?
>          (buf->reserved2 & ATOMISP_BUFFER_HAS_PER_FRAME_SETTING)) {
>              ^~
>    drivers/staging/media//atomisp/pci/atomisp2/atomisp_ioctl.c:1299:50: error: 'struct v4l2_buffer' has no member named 'reserved2'; did you mean 'reserved'?
>       pipe->frame_request_config_id[buf->index] = buf->reserved2 &
>                                                      ^~
>    drivers/staging/media//atomisp/pci/atomisp2/atomisp_ioctl.c: In function 'atomisp_dqbuf':
>    drivers/staging/media//atomisp/pci/atomisp2/atomisp_ioctl.c:1483:5: error: 'struct v4l2_buffer' has no member named 'reserved2'; did you mean 'reserved'?
>      buf->reserved2 = pipe->frame_config_id[buf->index];
>         ^~
>    In file included from include/linux/printk.h:329:0,
>                     from include/linux/kernel.h:13,
>                     from include/linux/delay.h:21,
>                     from drivers/staging/media//atomisp/pci/atomisp2/atomisp_ioctl.c:24:
>    drivers/staging/media//atomisp/pci/atomisp2/atomisp_ioctl.c:1488:6: error: 'struct v4l2_buffer' has no member named 'reserved2'; did you mean 'reserved'?
>       buf->reserved2);
>          ^

Ouch! Seems the reserved2 was burned down by 2 drivers accessing it
without any care for the uAPI. I'll change my patches to use the
'reserved' field instead.

	Gustavo

  reply	other threads:[~2017-06-26 15:39 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16  7:39 [PATCH 00/12] V4L2 explicit synchronization support Gustavo Padovan
2017-06-16  7:39 ` [PATCH 01/12] [media] vb2: add explicit fence user API Gustavo Padovan
2017-06-18 14:09   ` kbuild test robot
2017-06-18 14:58   ` kbuild test robot
2017-06-26 15:39     ` Gustavo Padovan [this message]
2017-07-04  5:57       ` Tomasz Figa
2017-07-04  6:27         ` Alexandre Courbot
2017-06-30 11:12   ` Mauro Carvalho Chehab
2017-06-16  7:39 ` [PATCH 02/12] [media] vb2: split out queueing from vb_core_qbuf() Gustavo Padovan
2017-06-30 11:15   ` Mauro Carvalho Chehab
2017-07-06  7:46   ` Hans Verkuil
2017-07-07  1:04     ` Gustavo Padovan
2017-06-16  7:39 ` [PATCH 03/12] [media] vb2: add in-fence support to QBUF Gustavo Padovan
2017-06-18 15:36   ` kbuild test robot
2017-06-30 11:53   ` Mauro Carvalho Chehab
2017-07-03 18:16     ` Gustavo Padovan
2017-07-06  9:43       ` Hans Verkuil
2017-07-07  1:12         ` Gustavo Padovan
2017-07-06  8:29   ` Hans Verkuil
2017-07-07  1:53     ` Gustavo Padovan
2017-07-07  7:15       ` Hans Verkuil
2017-07-10 19:27         ` Gustavo Padovan
2017-07-06  9:18   ` Hans Verkuil
2017-07-07  2:00     ` Gustavo Padovan
2017-07-07  7:06       ` Hans Verkuil
2017-07-10 19:02         ` Gustavo Padovan
2017-07-10 20:26           ` Gustavo Padovan
2017-07-11  5:57             ` Hans Verkuil
2017-07-11 12:56               ` Gustavo Padovan
2017-06-16  7:39 ` [PATCH 04/12] [media] uvc: enable subscriptions to other events Gustavo Padovan
2017-07-07 14:38   ` Shuah Khan
2017-07-10 19:38     ` Gustavo Padovan
2017-07-26  0:26       ` Gustavo Padovan
2017-06-16  7:39 ` [PATCH 05/12] [media] vivid: assign the specific device to the vb2_queue->dev Gustavo Padovan
2017-07-06  8:36   ` Hans Verkuil
2017-07-07 17:15   ` Shuah Khan
2017-07-10 19:42     ` Gustavo Padovan
2017-07-26  0:17     ` Gustavo Padovan
2017-06-16  7:39 ` [PATCH 06/12] [media] v4l: add V4L2_EVENT_BUF_QUEUED event Gustavo Padovan
2017-06-30 12:00   ` Mauro Carvalho Chehab
2017-06-16  7:39 ` [PATCH 07/12] [media] v4l: add support to BUF_QUEUED event Gustavo Padovan
2017-06-30 12:04   ` Mauro Carvalho Chehab
2017-07-03 18:36     ` Gustavo Padovan
2017-07-06  9:34     ` Hans Verkuil
2017-07-10 19:45       ` Gustavo Padovan
2017-07-06  8:47   ` Hans Verkuil
2017-06-16  7:39 ` [PATCH 08/12] [media] vb2: add 'ordered' property to queues Gustavo Padovan
2017-06-16 16:56   ` Nicolas Dufresne
2017-06-26 15:22     ` Gustavo Padovan
2017-07-06  9:08   ` Hans Verkuil
2017-06-16  7:39 ` [PATCH 09/12] [media] vivid: mark vivid queues as ordered Gustavo Padovan
2017-07-06  8:37   ` Hans Verkuil
2017-07-07 17:31   ` Shuah Khan
2017-07-10 19:47     ` Gustavo Padovan
2017-06-16  7:39 ` [PATCH 10/12] [media] vb2: add videobuf2 dma-buf fence helpers Gustavo Padovan
2017-06-16  7:39 ` [PATCH 11/12] [media] vb2: add infrastructure to support out-fences Gustavo Padovan
2017-06-16  7:39 ` [PATCH 12/12] [media] vb2: add out-fence support to QBUF Gustavo Padovan
2017-07-06  9:27   ` Hans Verkuil
2017-07-06  9:29   ` Hans Verkuil
2017-07-10 20:19     ` Gustavo Padovan
2017-06-30 12:18 ` [PATCH 00/12] V4L2 explicit synchronization support Mauro Carvalho Chehab
2017-07-03 18:40   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170626153936.GB3090@jade \
    --to=gustavo@padovan.org \
    --cc=gustavo.padovan@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=javier@osg.samsung.com \
    --cc=kbuild-all@01.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mchehab@osg.samsung.com \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox