Linux Media Controller development
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, pavel@ucw.cz
Subject: Re: [PATCH 3/8] v4l: fwnode: Call CSI2 bus csi2, not csi
Date: Thu, 6 Jul 2017 13:07:45 +0200	[thread overview]
Message-ID: <20170706110745.2qpfeh2dkfxfxynw@earth> (raw)
In-Reply-To: <20170705230019.5461-4-sakari.ailus@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]

Hi,

On Thu, Jul 06, 2017 at 02:00:14AM +0300, Sakari Ailus wrote:
> The function to parse CSI2 bus parameters was called
> v4l2_fwnode_endpoint_parse_csi_bus(), rename it as
> v4l2_fwnode_endpoint_parse_csi2_bus() in anticipation of CSI1/CCP2
> support.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> ---
>  drivers/media/v4l2-core/v4l2-fwnode.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
> index 153c53ca3925..8df26010d006 100644
> --- a/drivers/media/v4l2-core/v4l2-fwnode.c
> +++ b/drivers/media/v4l2-core/v4l2-fwnode.c
> @@ -28,8 +28,8 @@
>  
>  #include <media/v4l2-fwnode.h>
>  
> -static int v4l2_fwnode_endpoint_parse_csi_bus(struct fwnode_handle *fwnode,
> -					      struct v4l2_fwnode_endpoint *vep)
> +static int v4l2_fwnode_endpoint_parse_csi2_bus(struct fwnode_handle *fwnode,
> +					       struct v4l2_fwnode_endpoint *vep)
>  {
>  	struct v4l2_fwnode_bus_mipi_csi2 *bus = &vep->bus.mipi_csi2;
>  	bool have_clk_lane = false;
> @@ -176,7 +176,7 @@ int v4l2_fwnode_endpoint_parse(struct fwnode_handle *fwnode,
>  	memset(&vep->bus_type, 0, sizeof(*vep) -
>  	       offsetof(typeof(*vep), bus_type));
>  
> -	rval = v4l2_fwnode_endpoint_parse_csi_bus(fwnode, vep);
> +	rval = v4l2_fwnode_endpoint_parse_csi2_bus(fwnode, vep);
>  	if (rval)
>  		return rval;
>  	/*
> -- 
> 2.11.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-07-06 11:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 23:00 [PATCH 0/8] Prepare for CCP2 / CSI-1 support, omap3isp fixes Sakari Ailus
2017-07-05 23:00 ` [PATCH 1/8] dt: bindings: Explicitly specify bus type Sakari Ailus
2017-07-05 23:00 ` [PATCH 2/8] dt: bindings: Add strobe property for CCP2 Sakari Ailus
2017-07-05 23:00 ` [PATCH 3/8] v4l: fwnode: Call CSI2 bus csi2, not csi Sakari Ailus
2017-07-06 11:07   ` Sebastian Reichel [this message]
2017-07-05 23:00 ` [PATCH 4/8] v4l: fwnode: Obtain data bus type from FW Sakari Ailus
2017-07-06 11:08   ` Sebastian Reichel
2017-07-05 23:00 ` [PATCH 5/8] v4l: Add support for CSI-1 and CCP2 busses Sakari Ailus
2017-07-06 11:08   ` Sebastian Reichel
2017-07-19 19:37   ` Mauro Carvalho Chehab
2017-07-19 20:53     ` Sakari Ailus
2017-07-19 20:56       ` Mauro Carvalho Chehab
2017-07-20  7:32       ` Pavel Machek
2017-07-05 23:00 ` [PATCH 6/8] smiapp: add CCP2 support Sakari Ailus
2017-07-05 23:00 ` [PATCH 7/8] omap3isp: Check for valid port in endpoints Sakari Ailus
2017-07-06 11:11   ` Sebastian Reichel
2017-07-07 13:04     ` Sakari Ailus
2017-07-13 11:12       ` Pavel Machek
2017-07-05 23:00 ` [PATCH 8/8] omap3isp: Destroy CSI-2 phy mutexes in error and module removal Sakari Ailus
2017-07-06 10:43 ` [PATCH 0/8] Prepare for CCP2 / CSI-1 support, omap3isp fixes Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706110745.2qpfeh2dkfxfxynw@earth \
    --to=sebastian.reichel@collabora.co.uk \
    --cc=linux-media@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox