* [PATCH] [media] ddbridge: constify i2c_algorithm structure
@ 2017-07-10 15:12 Daniel Scheller
2017-07-23 10:18 ` Daniel Scheller
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Scheller @ 2017-07-10 15:12 UTC (permalink / raw)
To: linux-media, mchehab, mchehab; +Cc: jasmin, garsilva
From: Daniel Scheller <d.scheller@gmx.net>
Original patch and issue identified by Gustavo A. R. Silva
<garsilva@embeddedor.com> via [1] using Coccinelle. While at it, even
mark the struct static again since it isn't referenced anywhere else.
[1] http://www.spinics.net/lists/linux-media/msg118221.html
Cc: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
---
drivers/media/pci/ddbridge/ddbridge-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/ddbridge/ddbridge-i2c.c b/drivers/media/pci/ddbridge/ddbridge-i2c.c
index 22b2543da4ca..3d0aefe05cec 100644
--- a/drivers/media/pci/ddbridge/ddbridge-i2c.c
+++ b/drivers/media/pci/ddbridge/ddbridge-i2c.c
@@ -212,7 +212,7 @@ static u32 ddb_i2c_functionality(struct i2c_adapter *adap)
return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
}
-struct i2c_algorithm ddb_i2c_algo = {
+static const struct i2c_algorithm ddb_i2c_algo = {
.master_xfer = ddb_i2c_master_xfer,
.functionality = ddb_i2c_functionality,
};
--
2.13.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] ddbridge: constify i2c_algorithm structure
2017-07-10 15:12 [PATCH] [media] ddbridge: constify i2c_algorithm structure Daniel Scheller
@ 2017-07-23 10:18 ` Daniel Scheller
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Scheller @ 2017-07-23 10:18 UTC (permalink / raw)
To: linux-media, mchehab, mchehab; +Cc: jasmin
Am Mon, 10 Jul 2017 17:12:27 +0200
schrieb Daniel Scheller <d.scheller.oss@gmail.com>:
> From: Daniel Scheller <d.scheller@gmx.net>
>
> Original patch and issue identified by Gustavo A. R. Silva
> <garsilva@embeddedor.com> via [1] using Coccinelle. While at it, even
> mark the struct static again since it isn't referenced anywhere else.
>
> [1] http://www.spinics.net/lists/linux-media/msg118221.html
>
> Cc: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
> ---
> drivers/media/pci/ddbridge/ddbridge-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/ddbridge/ddbridge-i2c.c
> b/drivers/media/pci/ddbridge/ddbridge-i2c.c index
> 22b2543da4ca..3d0aefe05cec 100644 ---
> a/drivers/media/pci/ddbridge/ddbridge-i2c.c +++
> b/drivers/media/pci/ddbridge/ddbridge-i2c.c @@ -212,7 +212,7 @@
> static u32 ddb_i2c_functionality(struct i2c_adapter *adap) return
> I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; }
>
> -struct i2c_algorithm ddb_i2c_algo = {
> +static const struct i2c_algorithm ddb_i2c_algo = {
> .master_xfer = ddb_i2c_master_xfer,
> .functionality = ddb_i2c_functionality,
> };
This one can be marked "Obsolete" in patchwork. Original ddbridge
patches have since been rebased (will re-send soonish), with this change
included.
Best regards,
Daniel Scheller
--
https://github.com/herrnst
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-23 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-10 15:12 [PATCH] [media] ddbridge: constify i2c_algorithm structure Daniel Scheller
2017-07-23 10:18 ` Daniel Scheller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).