Re: [PATCH 0/7] Omap3isp CCP2 support

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

Hi!

> I rebased the ccp2 branch and went through the patches. I didn't find
> anything really alarming there; I changed one commit description of
> "omap3isp: Correctly set IO_OUT_SEL and VP_CLK_POL for CCP2 mode" that had
> some junk in it as well as in the last patch changed the condition in
> omap3isp_csiphy_release() that was obviously wrong.
> 
> Let me know what you think.
> 
> If we merge these, is there anything still missing from plain ccp2
> support?

I believe we are fine.

Tested-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pavel Machek <pavel@ucw.cz>

There is still

commit 629fcfe04ef5f1aee5280b2e0208cc891503824a
Author: Pavel <pavel@ucw.cz>
Date:   Mon Feb 13 21:26:51 2017 +0100

    omap3isp: fix VP2SDR bit so capture (not preview) works

issue, but that's independend of ccp2 support, and driver is useful
without that fix. (Preview works ok, capture results in distorted
picture but...)

Plus I'll need to submit dts changes for N900, and subdev support for
camera flash/focus would be useful.

But with this series we have basic support in.

Best regards,
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]