From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:37577 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755466AbdGTNyl (ORCPT ); Thu, 20 Jul 2017 09:54:41 -0400 Date: Thu, 20 Jul 2017 10:54:34 -0300 From: Mauro Carvalho Chehab To: Kieran Bingham Cc: kieran.bingham@ideasonboard.com, Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 05/14] v4l: vsp1: Don't create links for DRM pipeline Message-ID: <20170720105434.1aee4cba@vento.lan> In-Reply-To: <883d6ab4-6f0f-aa2d-b38d-335987a4ca8b@ideasonboard.com> References: <20170626181226.29575-1-laurent.pinchart+renesas@ideasonboard.com> <20170626181226.29575-6-laurent.pinchart+renesas@ideasonboard.com> <883d6ab4-6f0f-aa2d-b38d-335987a4ca8b@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Thu, 13 Jul 2017 14:06:04 +0100 Kieran Bingham escreveu: > On 26/06/17 19:12, Laurent Pinchart wrote: > > When the VSP1 is used in a DRM pipeline the driver doesn't register the > > media device. Links between entities are not exposed to userspace, but > > are still used internally for the sole purpose of setting up internal > > source to sink pointers through the link setup handler. > > > > Instead of going through this complex procedure, remove link creation > > and set the sink pointers directly. > > > > Signed-off-by: Laurent Pinchart > > A whole function removed ... always love code removal... > > Reviewed-by: Kieran Bingham Acked-by: Mauro Carvalho Chehab Thanks, Mauro